Replace `cached_property` with `property` or `functools_property`

[Paillat-dev]

Summary

cached_property is often unnecessary and can be replaced with property or functools.cached_property (if some criteria are met)

What is the feature request for?

The core library

The Problem

The goal of cached_property is to prevent from recalculating compute (intensive) code when the result is not expected to change. However, it is used all over the place in the library without any scope. It does not cache any compute intensive code, and at best, makes it arguably less memory efficient. Also, it causes typing and documentation rendering issues.

The Ideal Solution

The solution would be to do the following for every usage of utils.cached_property :

• If no compute intensive code is present (90% of the cases), replace it with property
• If compute intensive code is present, and the function does not provide __dict__ in __slots__ (see here why, altough it should never be the case as pycord uses cached_slot_property, but is good to mention), repalce it with functools.cached_property.

With the goal of utlimately entirely removing cached_property.

The Current Solution

n/a

Additional Context

• ApplicationContext attributes have wrong type annotations #2635
• fix: use property instead of NewType(...) to fix type annotations for ApplicationContext attributes #2636
• https://discord.com/channels/881207955029110855/881735314987708456/1304609838101172286
• https://docs.python.org/3/library/functools.html#functools.cached_property

• pycord/discord/commands/context.py

  Line 223 in 61cc544

  @cached_property

• pycord/discord/commands/context.py

  Line 167 in 61cc544

  @cached_property

• And many more such examples

[RiccardoVaccari]

After #2636 all cached_property refer to the built-in property (utils.py line 153).
This issue is about removing this layer and changing all these "fake" cached_property to property. Is this right or am I missing something?

[plun1331]

After #2636 all cached_property refer to the built-in property (utils.py line 153). This issue is about removing this layer and changing all these "fake" cached_property to property. Is this right or am I missing something?

That was a type checking change, so that type checkers are able to properly handle cached_property