-
-
Notifications
You must be signed in to change notification settings - Fork 477
refactor: ♻️ Use typing_extensions
instead of _typed_dict
#2621
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
typing_extensions
instead of _typed_dict
typing_extensions
instead of _typed_dict
typing_extensions
instead of _typed_dict
typing_extensions
instead of _typed_dict
90fb22d
to
cf9d859
Compare
Does this need changelog ? |
cf9d859
to
ace2c1d
Compare
ace2c1d
to
77f5683
Compare
Nope, just need to test if this works for typing_extensions 4.0.0 since that's the lowest allowed version in the requirements. |
TypedDict has had changes after 4.0.0 (ref), we'd better test both older and newer versions. |
6eaa65d
to
43d218e
Compare
will do |
#2655 requires |
Two seperate pull requests, no need. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Well here we go
Summary
Information
fixes: Remove _typed_dict.py #2166
examples, ...).
Checklist
type: ignore
comments were used, a comment is also left explaining why.