refactor: Update Client.run to have a better async I/O usage

[DA-344]

Summary

This PR refactors the Client.run logic to fix problems involving asyncio due to how the library used the loop:

Needs testing

Exception

  File "/home/container/main.py", line 23, in <module>
    bot.run(BOT_TOKEN)

  File "/home/container/.local/lib/python3.11/site-packages/discord/client.py", line 772, in run
    loop.run_forever()

  File "/usr/local/lib/python3.11/asyncio/base_events.py", line 608, in run_forever
    self._run_once()

  File "/usr/local/lib/python3.11/asyncio/base_events.py", line 1936, in _run_once
    handle._run()

  File "/usr/local/lib/python3.11/asyncio/events.py", line 84, in _run
    self._context.run(self._callback, *self._args)

  File "/usr/local/lib/python3.11/asyncio/selector_events.py", line 956, in _read_ready
    self._read_ready_cb()

  File "/usr/local/lib/python3.11/asyncio/selector_events.py", line 988, in _read_ready__get_buffer
    self._protocol.buffer_updated(nbytes)

  File "/usr/local/lib/python3.11/asyncio/sslproto.py", line 439, in buffer_updated
    self._do_handshake()

  File "/usr/local/lib/python3.11/asyncio/sslproto.py", line 560, in _do_handshake
    self._sslobj.do_handshake()

  File "/usr/local/lib/python3.11/ssl.py", line 979, in do_handshake
    self._sslobj.do_handshake()

Information

• This PR fixes an issue.
• This PR adds something new (e.g. new method or parameters).
• This PR is a breaking change (e.g. methods or parameters removed/renamed).
• This PR is not a code change (e.g. documentation, README, typehinting,
  examples, ...).

Checklist

• I have searched the open pull requests for duplicates.
• If code changes were made then they have been tested.
  • I have updated the documentation to reflect the changes.
• If type: ignore comments were used, a comment is also left explaining why.
• I have updated the changelog to include these changes.

[DA-344]

Applied all the changes Dorukyum requested.

Before merging, I would like some feedback on this discussion message

[Lumabots]

i tested this pr on my prod bot for some hours and nothing to issue to signal

[DA-344]

I've done some testing and it has been working as expected. Can this pr get any review more/merge ?

[Paillat-dev]

This is required if we ever want py 3.14 support, see my pr about that

[DA-344]

Not just for 3.14 support, but to fix all asyncio related issues that can be presented in any version due to how the AbstractEventLoop is currently handled.

[VincentRPS]

LGTM

[Paillat-dev]

lgtm as long as that MISSING comment is resolved in some way or another, nice pr

[Paillat-dev]

Could be neat if we could get this merged for 2.7

[Paillat-dev]

Also please @DA-344 fix conflicts (sry 😅)

[Paillat-dev]

Need to test something

[Paillat-dev]

@DA-344 The test code below crashes, can you take a look ? I think it has to do with self.loop now being a property, maybe self._loop should be passed to HTTPClient but I am not 100% sure.

pycord/discord/client.py

Line 249 in 2ae01b7

loop=self.loop,

Traceback (most recent call last):
  File "C:\Users\Jérémie\Documents\GitHub\pycord\thing.py", line 12, in <module>
    bot = discord.Bot(intents=discord.Intents.all())
  File "C:\Users\Jérémie\Documents\GitHub\pycord\discord\bot.py", line 1171, in __init__
    super().__init__(*args, **options)
    ~~~~~~~~~~~~~~~~^^^^^^^^^^^^^^^^^^
  File "C:\Users\Jérémie\Documents\GitHub\pycord\discord\bot.py", line 97, in __init__
    super().__init__(*args, **kwargs)
    ~~~~~~~~~~~~~~~~^^^^^^^^^^^^^^^^^
  File "C:\Users\Jérémie\Documents\GitHub\pycord\discord\cog.py", line 610, in __init__
    super().__init__(*args, **kwargs)
    ~~~~~~~~~~~~~~~~^^^^^^^^^^^^^^^^^
  File "C:\Users\Jérémie\Documents\GitHub\pycord\discord\client.py", line 250, in __init__
    loop=self.loop,
         ^^^^^^^^^
  File "C:\Users\Jérémie\Documents\GitHub\pycord\discord\client.py", line 330, in loop
    raise RuntimeError("loop is not set")
RuntimeError: loop is not set

Test Code

import os
import discord
import asyncio
import logging

from dotenv import load_dotenv

logging.basicConfig(level=logging.INFO)

load_dotenv()

bot = discord.Bot(intents=discord.Intents.all())

@bot.event
async def on_ready():
    print(f"Logged in as {bot.user} ({bot.user.id})")

options = [
    "Option 1",
    "Option 2",
    "Option 3",
    "Option 4",
]

async def my_autocomplete(ctx: discord.AutocompleteContext):
    """Autocomplete function for the command"""
    query = ctx.value.lower()
    return [option for option in options if query in option.lower()]


class MyCog(discord.Cog):
    """Example cog for the bot"""

    def __init__(self, bot: discord.Bot):
        self.bot: discord.Bot = bot

    @discord.command(name="hello")
    @discord.option(
        name="option",
        description="An example option",
        required=True,
        autocomplete=my_autocomplete,
    )
    async def hello(self, ctx: discord.ApplicationContext, option: str):
        await ctx.respond(f"Hello! You selected: {option}")


async def load_cogs():
    bot.add_cog(MyCog(bot))


async def main():
    await load_cogs()

    try:
        await bot.start(os.getenv("TOKEN_3", ""))
    except KeyboardInterrupt:
        await bot.close()


if __name__ == "__main__":
    asyncio.run(main())

[DA-344]

@DA-344 The test code below crashes, can you take a look ? I think it has to do with self.loop now being a property, maybe self._loop should be passed to HTTPClient but I am not 100% sure.

Yup, I forgot to update that to use _loop instead of loop, should be fixed now.