-
-
Notifications
You must be signed in to change notification settings - Fork 477
fix: support new voice encryption modes #2651
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
What about |
unlikely target for this PR, |
#2644 is potentially related? (I have no idea how voice works) |
Pretty sure no, it should error when it can't find an encryption type of it was related to this. It is able to successfully choose a voice type. Also, I think the problem is no one knows that much about voice XD |
@NeloBlivion is this ready ? Also is it possible to merge master in this ? |
To be honest I have no clue, but i'll remove it from draft; if people have it working then yeah merge i suppose |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please merge this in 2.7 I don't really know how to test this extensively but some people have been using it without problems and code looks good to me
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If something breaks it's on you then @Paillat-dev x3
Summary
Discord, in all their wisdom, decided to deprecate old encryption modes and have them removed in the span of 3 months.
Untested, please help
Information
examples, ...).
Checklist
type: ignore
comments were used, a comment is also left explaining why.