Skip to content

fix: support new voice encryption modes #2651

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Aug 7, 2025

Conversation

NeloBlivion
Copy link
Member

Summary

Discord, in all their wisdom, decided to deprecate old encryption modes and have them removed in the span of 3 months.
Untested, please help

Information

  • This PR fixes an issue.
  • This PR adds something new (e.g. new method or parameters).
  • This PR is a breaking change (e.g. methods or parameters removed/renamed).
  • This PR is not a code change (e.g. documentation, README, typehinting,
    examples, ...).

Checklist

  • I have searched the open pull requests for duplicates.
  • If code changes were made then they have been tested.
    • I have updated the documentation to reflect the changes.
  • If type: ignore comments were used, a comment is also left explaining why.
  • I have updated the changelog to include these changes.

@Icebluewolf
Copy link
Member

What about aead_aes256_gcm_rtpsize?

@NeloBlivion
Copy link
Member Author

NeloBlivion commented Nov 17, 2024

unlikely target for this PR, aead_xchacha20_poly1305_rtpsize was chosen for it's similarity to the existing methods and ease in switching over (alongside being required, while aead_aes256_gcm_rtpsize is optional)

@JustaSqu1d
Copy link
Member

#2644 is potentially related? (I have no idea how voice works)

@Icebluewolf
Copy link
Member

#2644 is potentially related? (I have no idea how voice works)

Pretty sure no, it should error when it can't find an encryption type of it was related to this. It is able to successfully choose a voice type. Also, I think the problem is no one knows that much about voice XD

@Paillat-dev
Copy link
Member

@NeloBlivion is this ready ? Also is it possible to merge master in this ?

@NeloBlivion
Copy link
Member Author

@NeloBlivion is this ready ? Also is it possible to merge master in this ?

To be honest I have no clue, but i'll remove it from draft; if people have it working then yeah merge i suppose

@NeloBlivion NeloBlivion marked this pull request as ready for review July 21, 2025 15:37
@NeloBlivion NeloBlivion requested a review from a team as a code owner July 21, 2025 15:37
@pullapprove4 pullapprove4 bot requested a review from plun1331 July 21, 2025 15:37
@pullapprove4 pullapprove4 bot requested a review from Middledot July 21, 2025 15:37
Copy link
Member

@Paillat-dev Paillat-dev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please merge this in 2.7 I don't really know how to test this extensively but some people have been using it without problems and code looks good to me

Copy link
Member

@Lulalaby Lulalaby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If something breaks it's on you then @Paillat-dev x3

@Lulalaby Lulalaby merged commit 8e2185c into Pycord-Development:master Aug 7, 2025
28 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants