feat: Respect user warning filters for deprecation messages

[Lumabots]

Summary

This PR removes the calls to warnings.simplefilter("always", DeprecationWarning) and warnings.simplefilter("default", DeprecationWarning) in the deprecation helper.

Currently, the implementation forces DeprecationWarning visibility by temporarily setting the filter to "always", and then resets it to "default". This overrides user-defined warning filters, which is not ideal.

With this change, the function simply calls warnings.warn, leaving all filtering behavior up to the user or their framework (e.g. pytest, PYTHONWARNINGS, warnings.filterwarnings).

Information

• This PR fixes an issue.
• This PR adds something new (e.g. new method or parameters).
• This PR is a breaking change (e.g. methods or parameters removed/renamed).
• This PR is not a code change (e.g. documentation, README, typehinting,
  examples, ...).

Checklist

• I have searched the open pull requests for duplicates.
• If code changes were made then they have been tested.
  • I have updated the documentation to reflect the changes.
• If type: ignore comments were used, a comment is also left explaining why.
• I have updated the changelog to include these changes.

[Lumabots]

i dont think this deserve a changelog

[Lumabots]

[Dorukyum]

Hold on, does the default behavior make the deprecation warnings visible?

[Lulalaby]

According to a quick research, no. Users would've to opt-in

[Paillat-dev]

Would it be possible for pycord to make it opt out instead without forcing them

[Lulalaby]

I think that's what warnings.simplefilter("default", DeprecationWarning) is for

[Lumabots]

I didn't test it yet, I'll test this tonight
But for me the edit back to default will reset the user settings so shouldn't be use at all.
And same so for the always which doesn't make any sense to me

[Lumabots]

after testing, its working great without those 2 lines, we can easily ignore those warning globally or within a with ..

[Lulalaby]

So the default configuration used by python does work?

[Lumabots]

So the default configuration used by python does work?

The default one does raise the warning, so we don't need to add any filter.

[Lulalaby]

Fine with me then

[Paillat-dev]

Do you have some docs / other ref about the default behaviour ?

[Lumabots]

Do you have some docs / other ref about the default behaviour ?

https://docs.python.org/3/library/warnings.html

but its mainly about the filters, there is no need to add a filter here since we are not filtering anything but emitting a warn