feat: added Interaction.attachment_size_limit #2854
Merged
+16
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: hich4t <[email protected]>
Signed-off-by: hich4t <[email protected]>
hich4t
changed the title
Lulalaby
reviewed
Aug 4, 2025
Signed-off-by: hich4t <[email protected]>
Paillat-dev
requested changes
Aug 4, 2025
There was a problem hiding this comment.
Hi, thanks for the pr ! Could you please do the following to make sure the pr is merged:
- Edit the
CHANGELOG.mdfile at the root of the repository to add under the## Addedsection your addition, making sure to keep the same format as the other entries. - Add a shortcut as a property to
ApplicationContextnamedattachment_size_limitthat returns the related interaction'sattachment_size_limit. - Add
attachment_size_limitto theInteraction's type class.
Paillat-dev
added
the
hold: changelog
Signed-off-by: hich4t <[email protected]>
Signed-off-by: hich4t <[email protected]>
Paillat-dev
requested changes
Aug 5, 2025
There was a problem hiding this comment.
I think you missed the third one
Add
attachment_size_limitto theInteraction's type class.
|
Paillat-dev
requested changes
Aug 5, 2025
Oops I missed it bc the two commits were named the same |
Co-authored-by: Paillat <[email protected]> Signed-off-by: hich4t <[email protected]>
Co-authored-by: Paillat <[email protected]> Signed-off-by: hich4t <[email protected]>
Paillat-dev
reviewed
Aug 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
added Interaction.attachment_size_limit
Information
examples, ...).
Checklist
type: ignorecomments were used, a comment is also left explaining why.