Validate an argument using the new api_version() method, also implement that method on wrapper classes #3717
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes # n/a
Summary/Motivation:
#3699 created a new api_version() method that can be queried to determine which api version a solver object supports. Use that method to validate a solver object argument in multiple_bigm.py, rather than using
isinstance
in a questionable way.Along the way I noticed that contrib LegacySolverWrapper and appsi LegacySolverInterface class instances were returning V2 and APPSI as their api versions which is not correct, so I added an override to api_version() there.
Changes proposed in this PR:
Legal Acknowledgement
By contributing to this software project, I have read the contribution guide and agree to the following terms and conditions for my contribution: