Skip to content
This repository was archived by the owner on Jul 12, 2020. It is now read-only.

Lock dependencies and fix tests #66

Merged
merged 3 commits into from
Apr 14, 2015

Conversation

tomphp
Copy link
Contributor

@tomphp tomphp commented Apr 13, 2015

This PR does the following:

  • Requires PHPUnit rather than assuming it is installed globally
  • Locks Symfony component versions to 2.*
  • Locks Behat to version 2.*
  • Updates Behat's FeatureContext to use local PHPUnit assert function
  • Locks tomphp/patch-builder to version 0.1.* (I'm planning some work on this which may cause BC breaks locking will avoid being affected).

@tomphp tomphp force-pushed the feature/patch-builder-version branch from 90a4fcc to 965ec9b Compare April 13, 2015 17:40
@tomphp
Copy link
Contributor Author

tomphp commented Apr 13, 2015

I've just notices isses #59 which duplicates some of this PR. This PR could be merged instead or it could be merged first and I can rebase.

closes #59

@tomphp tomphp changed the title Look dependencies and fix tests Lock dependencies and fix tests Apr 13, 2015
@tomphp tomphp force-pushed the feature/patch-builder-version branch from 965ec9b to 2cfc46c Compare April 13, 2015 22:13
beberlei added a commit that referenced this pull request Apr 14, 2015
@beberlei beberlei merged commit e3f967d into QafooLabs:master Apr 14, 2015
@beberlei
Copy link
Contributor

@tomphp somehow it requires symfony/filesystem 3.0 dev and that is >= 5.5, failing the 5.4 tests. Can you fix that?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants