Update mpl_draw() to fix multigraph plots

[maxwell04-wq]

Fixes #774.
Updates:

• draw_edges(): set rad=0.25 for looped nodes.
• draw_edge_labels(): Modify label offsets for looped nodes.

[coveralls]

Pull Request Test Coverage Report for Build 9448236772

Details

• 0 of 0 changed or added relevant lines in 0 files are covered.
• 8 unchanged lines in 2 files lost coverage.
• Overall coverage decreased (-0.04%) to 95.837%

---

Files with Coverage Reduction	New Missed Lines	%
rustworkx-core/src/generators/random_graph.rs	2	85.04%
src/shortest_path/all_pairs_bellman_ford.rs	6	95.53%

Totals
Change from base Build 9447555728:	-0.04%
Covered Lines:	17380
Relevant Lines:	18135

---

💛 - Coveralls

[maxwell04-wq]

@mtreinish one major hiccup in the implementation is that the position of the edges is calculated on the plot in the draw_edges() function and the position of the labels can only be evaluated relative to the position of the nodes and not the edges in the draw_edge_labels() function. While the current parameters for the curved edges of multigraphs work for plotting the labels, maybe there's a better way to evaluate the position of the labels.

[IvanIsCoding]

I think we need to work on the loop condition. You'll also need to add a release note (https://github.com/Qiskit/rustworkx/blob/main/CONTRIBUTING.md#release-notes)

[IvanIsCoding]

I think there are easier and simpler ways to write this. I don't quite understand why we are using NumPy for this check either

[maxwell04-wq]

@IvanIsCoding I have not tried to align the labels vertically as, following the logic of rad in connectionstyle=arc3, simply offsetting the y coordinates of labels to rad generates a figure wherein the labels are perfectly placed on the edges.

Would you suggest that I work on aligning the edge labels?

[IvanIsCoding]

So this scales quadratically on the number of edges. O(E^2) is not ideal, if we plot a dense graph this is going to be a problem. You need to rewrite this condition using a set or something similar instead of naively looking through all the edges

[IvanIsCoding]

You don't need the other section

[IvanIsCoding]

The release notes would be better if you actually drew a multigraph with mpl_draw as an example. You can use

rustworkx/releasenotes/notes/0.14/add-albert-graph-5a7d393e1fe18e9d.yaml

Line 16 in 5354512

mpl_draw(random_graph)

as an example, it becomes this: https://www.rustworkx.org/release_notes.html#new-features

[IvanIsCoding]

It seems to be working, I will merge the PR