[DEM-943] Feature UHFLI integration #573

CumulonimbusCalvus · 2019-05-23T22:02:42Z

⛈ 🍝

src/qtt/measurements/scans.py

qSaevar

Almost all small comments about form and style

docs/notebooks/unfinished/example_UHFLI_measurements.py

src/qtt/measurements/scans.py

src/qtt/measurements/videomode.py

qSaevar

Some suggestions, you can take them or not.

qSaevar · 2019-06-26T06:29:10Z

docs/notebooks/unfinished/example_process_sawtooth_2d.py

 width = [upwards_edge_pixels_x/pixels_x, upwards_edge_pixels_y/pixels_y]
 resolution = [pixels_x, pixels_y]

-
-def create_dummy_data_array(width: float, sawteeth_count: int, channel_index: int = 1, trace_number: int = 1):
+def create_dummy_data_array(width: float, processing: str, sawteeth_count: int, channel_index: int = 1, trace_number: int = 1) -> DataArray:


This line is to long, and a missing blank line above

docs/notebooks/unfinished/example_process_sawtooth_2d.py

src/qtt/measurements/acquisition/interfaces/acquisition_scope_interface.py

src/qtt/measurements/acquisition/uhfli_scope_reader.py

Co-Authored-By: qSaevar <[email protected]>

…interface.py Co-Authored-By: qSaevar <[email protected]>

Co-Authored-By: qSaevar <[email protected]>

…interface.py Co-Authored-By: qSaevar <[email protected]>

CumulonimbusCalvus force-pushed the feature/DEM-943/UHFLI_integration branch 3 times, most recently from d4bc1df to 6b8d994 Compare May 24, 2019 15:12

peendebak reviewed May 24, 2019

View reviewed changes

src/qtt/measurements/scans.py Outdated Show resolved Hide resolved

CumulonimbusCalvus force-pushed the feature/DEM-943/UHFLI_integration branch from 6b8d994 to 75e5a93 Compare May 27, 2019 15:33

peendebak force-pushed the feature/DEM-943/UHFLI_integration branch from 75e5a93 to 3d1d053 Compare May 29, 2019 13:10

CumulonimbusCalvus force-pushed the feature/DEM-943/UHFLI_integration branch 2 times, most recently from ea8f53a to f8ef796 Compare June 13, 2019 05:55

qSaevar reviewed Jun 18, 2019

View reviewed changes

CumulonimbusCalvus force-pushed the feature/DEM-943/UHFLI_integration branch 3 times, most recently from 78845ea to 90d1b37 Compare June 21, 2019 12:57

CumulonimbusCalvus added 17 commits June 25, 2019 14:15

Moved number of averages to scope reader acquire.

bf9a312

Updated processing example.

7d6b14c

Added channel limit setter.

05ebb81

Added combined example. Changed to old processing.

11911e3

Added segment scope reader tests.

6c16fbb

[DEM-943] Removed needed ScopeReader name in scans.

33ebd7d

[DEM-943] Unit scope reader.

37069a9

[DEM-943] Updated stimulus functions.

7b393c8

[DEM-943] Changed default arguments.

f64c352

[DEM-943] Resolved review comments.

e3bb069

[DEM-943] Changed output marker and sweep initial waiting time.

685ea27

[DEM-943] Decorated property not supported (python/mypy#1362).

dcf347d

[DEM-943] Fix type-hinting.

1473f06

[DEM-943] Fix unittests.

43e5944

[DEM-943] Enable external clock UHFLI.

a02b8f8

[DEM-943] Map misses setting first channel.

469e64d

[DEM-943] Data is one element longer?

5ce0c56

CumulonimbusCalvus force-pushed the feature/DEM-943/UHFLI_integration branch from 50e4ebb to 5ce0c56 Compare June 25, 2019 12:15

qSaevar reviewed Jun 26, 2019

View reviewed changes

CumulonimbusCalvus and others added 23 commits June 26, 2019 10:37

Update docs/notebooks/unfinished/example_process_sawtooth_2d.py

314b6b2

Co-Authored-By: qSaevar <[email protected]>

Update src/qtt/measurements/acquisition/interfaces/acquisition_scope_…

e914c05

…interface.py Co-Authored-By: qSaevar <[email protected]>

Update src/qtt/measurements/acquisition/interfaces/acquisition_scope_…

8e85a27

…interface.py Co-Authored-By: qSaevar <[email protected]>

Update src/qtt/measurements/acquisition/interfaces/acquisition_scope_…

b533c1f

…interface.py Co-Authored-By: qSaevar <[email protected]>

Update src/qtt/measurements/acquisition/uhfli_scope_reader.py

1ab0b66

Co-Authored-By: qSaevar <[email protected]>

Update src/qtt/measurements/acquisition/interfaces/acquisition_scope_…

4b36e71

…interface.py Co-Authored-By: qSaevar <[email protected]>

Update src/qtt/measurements/acquisition/interfaces/acquisition_scope_…

17c121c

…interface.py Co-Authored-By: qSaevar <[email protected]>

Update src/qtt/measurements/acquisition/interfaces/acquisition_scope_…

30700fb

…interface.py Co-Authored-By: qSaevar <[email protected]>

Update src/qtt/measurements/acquisition/interfaces/acquisition_scope_…

df70ab0

…interface.py Co-Authored-By: qSaevar <[email protected]>

Update src/qtt/measurements/acquisition/interfaces/acquisition_scope_…

1e7dac6

…interface.py Co-Authored-By: qSaevar <[email protected]>

Update src/qtt/measurements/acquisition/interfaces/acquisition_scope_…

9d5db6a

…interface.py Co-Authored-By: qSaevar <[email protected]>

Update src/qtt/measurements/acquisition/interfaces/acquisition_scope_…

9e2caae

…interface.py Co-Authored-By: qSaevar <[email protected]>

Update src/qtt/measurements/acquisition/interfaces/acquisition_scope_…

34f5c67

…interface.py Co-Authored-By: qSaevar <[email protected]>

Update src/qtt/measurements/acquisition/interfaces/acquisition_scope_…

80bc3dd

…interface.py Co-Authored-By: qSaevar <[email protected]>

Update src/qtt/measurements/acquisition/interfaces/acquisition_scope_…

2f2aa9d

…interface.py Co-Authored-By: qSaevar <[email protected]>

Update src/qtt/measurements/acquisition/interfaces/acquisition_scope_…

11bf73e

…interface.py Co-Authored-By: qSaevar <[email protected]>

Update src/qtt/measurements/acquisition/interfaces/acquisition_scope_…

37aa147

…interface.py Co-Authored-By: qSaevar <[email protected]>

Update src/qtt/measurements/acquisition/interfaces/acquisition_scope_…

bbfa5dc

…interface.py Co-Authored-By: qSaevar <[email protected]>

Update src/qtt/measurements/acquisition/interfaces/acquisition_scope_…

6b09e6a

…interface.py Co-Authored-By: qSaevar <[email protected]>

Update src/qtt/measurements/acquisition/interfaces/acquisition_scope_…

09ea48f

…interface.py Co-Authored-By: qSaevar <[email protected]>

Update src/qtt/measurements/acquisition/interfaces/acquisition_scope_…

9a6bba1

…interface.py Co-Authored-By: qSaevar <[email protected]>

Update src/qtt/measurements/acquisition/interfaces/acquisition_scope_…

cbb0c0f

…interface.py Co-Authored-By: qSaevar <[email protected]>

[DEM-943] Addressed review comments.

e71d7d9

qSaevar approved these changes Jun 26, 2019

View reviewed changes

CumulonimbusCalvus merged commit beaedca into dev Jun 26, 2019

CumulonimbusCalvus deleted the feature/DEM-943/UHFLI_integration branch August 16, 2019 15:41

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

[DEM-943] Feature UHFLI integration #573

[DEM-943] Feature UHFLI integration #573

Uh oh!

CumulonimbusCalvus commented May 23, 2019 •

edited

Loading

Uh oh!

Uh oh!

qSaevar left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

qSaevar left a comment

Uh oh!

qSaevar Jun 26, 2019

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

[DEM-943] Feature UHFLI integration #573

[DEM-943] Feature UHFLI integration #573

Uh oh!

Conversation

CumulonimbusCalvus commented May 23, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

qSaevar left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

qSaevar left a comment

Choose a reason for hiding this comment

Uh oh!

qSaevar Jun 26, 2019

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

CumulonimbusCalvus commented May 23, 2019 •

edited

Loading