Skip to content

fix amss2 lecture failure #171

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Dec 30, 2020
Merged

fix amss2 lecture failure #171

merged 3 commits into from
Dec 30, 2020

Conversation

shizejin
Copy link
Member

close #130

  1. add jacobian approximatyion function objf_prime and pass it to the slsqp minimization routine
  2. adjust the tolerance level of slsqp from 1e-12 to 1e-10

close #130

1. add jacobian approximatyion function `objf_prime` and pass it to the slsqp minimization routine
2. adjust the tolerance level of slsqp from 1e-12 to 1e-10
@shizejin
Copy link
Member Author

It looks like the deploying environment is not prepared correctly:

Error: ENOENT: no such file or directory, open '/home/runner/work/lecture-python-advanced/lecture-python-advanced/environment.yml'

If there anything I need to do to make testing work and the preview of the notebook available? Thanks!

@jstac
Copy link
Contributor

jstac commented Dec 30, 2020

Many thanks @shizejin

@mmcky, just when you have a moment, could you please review this PR?

@github-actions
Copy link

@mmcky
Copy link
Contributor

mmcky commented Dec 30, 2020

@shizejin this is now building. It is wonderful to see pass on the execution tests.

@mmcky mmcky merged commit dc7f1f6 into master Dec 30, 2020
@mmcky mmcky deleted the fix_amss2 branch December 30, 2020 22:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[amss2] Lecture failed nightly build
3 participants