Skip to content

RFC: Update the AMSS lectures #207

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jun 22, 2021
Merged

RFC: Update the AMSS lectures #207

merged 3 commits into from
Jun 22, 2021

Conversation

QBatista
Copy link
Member

@QBatista QBatista commented Jun 11, 2021

Refactor the code in the AMSS lectures to improve speed through just-in-time compilation and the code structure.

Three lectures need to be modified:

  • amss
  • amss2
  • amss3

Close #206 #203

@github-actions
Copy link

github-actions bot commented Jun 11, 2021

@mmcky
Copy link
Contributor

mmcky commented Jun 21, 2021

thanks @QBatista -- can you ping me with a review request when you want this merged?

Then I will merge, make live, and migrate this to the new myst repo as well.

@QBatista
Copy link
Member Author

@mmcky Sure!

@mmcky
Copy link
Contributor

mmcky commented Jun 21, 2021

@mmcky Sure!

@QBatista no pressure -- just for planning purposes -- do you have an estimated timeline for these updates?

Just thinking about when to migrate to the jupyter-book version :-)

@QBatista
Copy link
Member Author

@mmcky Hopefully I should be done within a few days.

@mmcky
Copy link
Contributor

mmcky commented Jun 21, 2021

thanks @QBatista

@QBatista QBatista changed the title [WIP] RFC: Update the AMSS lectures RFC: Update the AMSS lectures Jun 22, 2021
@QBatista
Copy link
Member Author

@mmcky This is ready for merging.

@mmcky
Copy link
Contributor

mmcky commented Jun 22, 2021

🎉 -- wow thanks for your help with this @QBatista. I'll merge now and it will build overnight on the build server.

Then I will migrate to lecture-python.myst in the morning

@mmcky mmcky merged commit 1964bc5 into master Jun 22, 2021
@mmcky mmcky deleted the amss_update branch June 22, 2021 10:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[amss] Broken from change to opt_tax_recur
2 participants