Skip to content
This repository was archived by the owner on Apr 24, 2020. It is now read-only.

FEAT: Add code execution testing through Travis CI #544

Merged
merged 5 commits into from
Aug 27, 2019
Merged

Conversation

mmcky
Copy link
Collaborator

@mmcky mmcky commented Aug 9, 2019

This PR will enable code execution checks for PR's. The travis instance will:

  1. compile changed RST files through sphinx
  2. run an execution check to make sure the notebook executes without error.

a green travis tick indicates the notebook executes without errors.

In the future travis can be expanded to include automatic deployment of html. See Issue #543

@mmcky
Copy link
Collaborator Author

mmcky commented Aug 9, 2019

  • migrate script components to bash script and include the conditional case of no changed files

@mmcky
Copy link
Collaborator Author

mmcky commented Aug 9, 2019

  • @mmcky to check behaviour of travis once this is merged to master

@mmcky mmcky added ready bug Something isn't working and removed ready labels Aug 9, 2019
@mmcky mmcky added ready and removed bug Something isn't working labels Aug 9, 2019
@mmcky
Copy link
Collaborator Author

mmcky commented Aug 9, 2019

@jstac this is ready -- but let's wait on merging this until next week after Tom has tried out jupinx.

@mmcky
Copy link
Collaborator Author

mmcky commented Aug 11, 2019

@jstac this should be independent of jupinx so happy for you to merge when you wish to try out execution testing on all PRs - that change any RST files. Scratch that -- this modifies Makefile so that is why I wrote the above. Let's leave this just in case for the week.

@mmcky mmcky added this to the 2019-08-16 milestone Aug 11, 2019
@mmcky mmcky added on-hold and removed on-hold labels Aug 13, 2019
@mmcky
Copy link
Collaborator Author

mmcky commented Aug 19, 2019

@jstac this is now ready for merge when you're ready to give CI a try on execution testing

@mmcky
Copy link
Collaborator Author

mmcky commented Aug 27, 2019

@jstac this no longer adjust the Makefile so I will go ahead and merge this to give it a trial run for any new incoming PRs. Let me know if it's a hassle and we can remove it.

@mmcky mmcky merged commit d7766e6 into master Aug 27, 2019
@mmcky mmcky deleted the add-travis-coverage branch August 27, 2019 06:31
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant