feat: Properly support S3 in IO functions #139
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Requires pola-rs/polars#23346 |
borchero
changed the title
delsner
reviewed
Sep 10, 2025
| ports: | ||
| - "1455:1433" | ||
|
|
||
| minio: |
There was a problem hiding this comment.
Did you consider using moto for s3 tests? It's easy to use and doesn't require running a container in the background (see http://docs.getmoto.org/en/latest/docs/server_mode.html#start-within-python).
There was a problem hiding this comment.
Ah neat, I remember that we had talked about this. I will investigate. Currently trying to fix the polars issue since this is a prerequisite anyways 😅
There was a problem hiding this comment.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Changes