Skip to content

updated api-extractor to latest #7528

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Apr 21, 2025
Merged

Conversation

sreeisalso
Copy link
Contributor

What is it?

  • Infra

Description

updated api-extractor to latest version, and found some naming confusions, referred microsoft/rushstack#4842 and made some changes

Checklist

  • My code follows the developer guidelines of this project
  • I performed a self-review of my own code
  • I added a changeset with pnpm change
  • I made corresponding changes to the Qwik docs
  • I added new tests to cover the fix / functionality

@sreeisalso sreeisalso requested a review from a team as a code owner April 21, 2025 07:52
Copy link

changeset-bot bot commented Apr 21, 2025

⚠️ No Changeset found

Latest commit: 209a265

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@sreeisalso sreeisalso marked this pull request as draft April 21, 2025 07:55
@wmertens
Copy link
Member

See the build/v2 branch, I did it there as well. I don't think we want to do it on v1 though, no real benefit.

@sreeisalso sreeisalso marked this pull request as ready for review April 21, 2025 08:43
Copy link

pkg-pr-new bot commented Apr 21, 2025

Open in StackBlitz

npm i https://pkg.pr.new/@builder.io/qwik@7528
npm i https://pkg.pr.new/@builder.io/qwik-city@7528
npm i https://pkg.pr.new/eslint-plugin-qwik@7528
npm i https://pkg.pr.new/create-qwik@7528

commit: 209a265

Copy link
Contributor

github-actions bot commented Apr 21, 2025

built with Refined Cloudflare Pages Action

⚡ Cloudflare Pages Deployment

Name Status Preview Last Commit
qwik-docs ✅ Ready (View Log) Visit Preview 209a265

Copy link
Member

@wmertens wmertens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok

@wmertens wmertens merged commit 4571b3c into QwikDev:main Apr 21, 2025
19 checks passed
@wmertens
Copy link
Member

Thanks!

@sreeisalso sreeisalso deleted the api-extractor-update branch April 21, 2025 10:57
@sreeisalso sreeisalso mentioned this pull request Apr 22, 2025
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants