fix(qwik-city): Link onQVisible$ handling

[maiieul]

What is it?

• Bug

Description

the onQVisible$ would only be fired once on first SPA load. Now it is fired on all subsequent route changes with the Link component.

Checklist

• My code follows the developer guidelines of this project
• I performed a self-review of my own code
• I added a changeset with pnpm change
• I made corresponding changes to the Qwik docs
• I added new tests to cover the fix / functionality

[changeset-bot]

🦋 Changeset detected

Latest commit: 27c7bda

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 4 packages

Name	Type
@builder.io/qwik-city	Patch
eslint-plugin-qwik	Patch
@builder.io/qwik	Patch
create-qwik	Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

[pkg-pr-new]

Open in StackBlitz

npm i https://pkg.pr.new/@builder.io/qwik@7612

npm i https://pkg.pr.new/@builder.io/qwik-city@7612

npm i https://pkg.pr.new/eslint-plugin-qwik@7612

npm i https://pkg.pr.new/create-qwik@7612

commit: 27c7bda

[github-actions]

built with Refined Cloudflare Pages Action

⚡ Cloudflare Pages Deployment

Name	Status	Preview	Last Commit
qwik-docs	✅ Ready (View Log)	Visit Preview	27c7bda

[maiieul]

@jordanw66 do you see anything that's bothering you / that could be improved?

[wmertens]

[jordanw66]

@jordanw66 do you see anything that's bothering you / that could be improved?

It's good, the only thing I wonder is if custom onQVisible$ props should be called on each route change vs just doing prefetch.

The onQVisible$ props already works a certain way on every component, with this change it means it would work different only on Link. Should it re-run all of the props handlers on each change or should it keep the default behavior and instead only run prefetch on route changes?