Skip to content

fix: proper empty props diffing #7633

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 22, 2025
Merged

Conversation

Varixo
Copy link
Member

@Varixo Varixo commented May 22, 2025

If component has empty props we don't need to compare them

@Varixo Varixo self-assigned this May 22, 2025
@Varixo Varixo requested a review from a team as a code owner May 22, 2025 18:41
Copy link

changeset-bot bot commented May 22, 2025

🦋 Changeset detected

Latest commit: 5b3a514

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@Varixo Varixo moved this from Backlog to Waiting For Review in Qwik Development May 22, 2025
Copy link

pkg-pr-new bot commented May 22, 2025

Open in StackBlitz

npm i https://pkg.pr.new/QwikDev/qwik/@qwik.dev/core@7633
npm i https://pkg.pr.new/QwikDev/qwik/@qwik.dev/router@7633
npm i https://pkg.pr.new/QwikDev/qwik/eslint-plugin-qwik@7633
npm i https://pkg.pr.new/QwikDev/qwik/create-qwik@7633

commit: 5b3a514

Copy link
Contributor

github-actions bot commented May 22, 2025

built with Refined Cloudflare Pages Action

⚡ Cloudflare Pages Deployment

Name Status Preview Last Commit
qwik-docs ✅ Ready (View Log) Visit Preview 5b3a514

Copy link
Member

@wmertens wmertens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wmertens wmertens merged commit e38fff6 into build/v2 May 22, 2025
19 checks passed
@wmertens wmertens deleted the v2-dont-rerender-empty-props branch May 22, 2025 19:06
@github-project-automation github-project-automation bot moved this from Waiting For Review to Done in Qwik Development May 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants