Skip to content

fix(qwik-city): q-data.json redirect handling #7988

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Sep 24, 2025
Merged

fix(qwik-city): q-data.json redirect handling #7988

merged 4 commits into from
Sep 24, 2025

Conversation

wmertens
Copy link
Member

@wmertens wmertens commented Sep 23, 2025 •
edited
Loading

  • make redirects work for q-data.json requests
  • don't redirect to captive portal while prefetching
  • re-enable redirects for the docs site

fixes #7977

@wmertens wmertens requested review from a team as code owners September 23, 2025 07:27
@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Sep 23, 2025 •
edited
Loading

🦋 Changeset detected

Latest commit: 9fa4290

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 4 packages
Name Type
@builder.io/qwik-city Patch
eslint-plugin-qwik Patch
@builder.io/qwik Patch
create-qwik Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@wmertens wmertens force-pushed the qc-fix-qdata-redirects branch from 17e221a to 9a20ff1 Compare September 23, 2025 07:50
@wmertens wmertens requested a review from a team as a code owner September 23, 2025 07:50
gioboa
gioboa previously approved these changes Sep 23, 2025
View reviewed changes
Copy link
Member

@gioboa gioboa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤞 Thanks @wmertens

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Sep 23, 2025 •
edited
Loading

built with Refined Cloudflare Pages Action

⚡ Cloudflare Pages Deployment

Name Status Preview Last Commit
qwik-docs ✅ Ready (View Log) Visit Preview 9fa4290

@wmertens wmertens force-pushed the qc-fix-qdata-redirects branch from 9a20ff1 to ec25630 Compare September 24, 2025 14:09
gioboa
gioboa previously approved these changes Sep 24, 2025
View reviewed changes
@wmertens wmertens enabled auto-merge September 24, 2025 14:57
maiieul
maiieul reviewed Sep 24, 2025
View reviewed changes
@pkg-pr-new pkg.pr.new
Copy link

pkg-pr-new bot commented Sep 24, 2025

Open in StackBlitz

npm i https://pkg.pr.new/@builder.io/qwik@7988

npm i https://pkg.pr.new/@builder.io/qwik-city@7988

npm i https://pkg.pr.new/eslint-plugin-qwik@7988

npm i https://pkg.pr.new/create-qwik@7988

commit: 9fa4290

@wmertens wmertens merged commit be79ad2 into main Sep 24, 2025
22 checks passed
@wmertens wmertens deleted the qc-fix-qdata-redirects branch September 24, 2025 16:03
@github-actions github-actions bot mentioned this pull request Oct 2, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@maiieul maiieul maiieul approved these changes

@gioboa gioboa gioboa left review comments

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[📖] Docs redirect everytime i search "ani"

3 participants

@wmertens @gioboa @maiieul