Skip to content

Add support for launching via Heroic #113

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 16, 2025
Merged

Add support for launching via Heroic #113

merged 2 commits into from
May 16, 2025

Conversation

rivques
Copy link
Contributor

@rivques rivques commented May 16, 2025

Hi!
This is a PR to add the ability to launch with the Heroic games launcher via the custom launcher setting. It's pretty simple, but I have no idea what the conventions are in this project, so please don't hesitate to provide feedback or bring up something I missed!

Copy link
Collaborator

@VirxEC VirxEC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR! Heroic is very popular on Linux especially, and supporting it would be awesome.

I assume this PR has been tested (at least on Linux) and that it successfully launches the game.

@VirxEC VirxEC requested a review from NicEastvillage May 16, 2025 02:38
Copy link
Collaborator

@VirxEC VirxEC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for the contribution - just going to wait for East to take a peek.

Copy link
Contributor

@NicEastvillage NicEastvillage left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR! Can't test it since I don't use Heroic. Let's assume it works :D

@VirxEC VirxEC merged commit fcd9222 into RLBot:master May 16, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants