-
Notifications
You must be signed in to change notification settings - Fork 110
Show kernel time when using gpu-driver #1289
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report
@@ Coverage Diff @@
## develop #1289 +/- ##
========================================
Coverage 93.14% 93.14%
========================================
Files 437 437
Lines 14297 14297
========================================
Hits 13317 13317
Misses 980 980 Continue to review full report at Codecov.
|
Check results before merge 🔆 |
Check results before merge 🔆 |
for(auto i : range(n)) | ||
{ | ||
(void)i; | ||
host_time += time<milliseconds>(run); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can we switch from milliseconds to microseconds? I know hipEventElapsedTime
returns time in ms, but it's resolution is approximately 1 microsecond. So multiplying the result by 1000. This is more for readability as we could be dealing with smaller kernels or small improvements to a bigger kernel.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The host time is usually pretty large, and it would make the time inconsistent with the perf report.
This build is not recommended to merge 🔴 |
No description provided.