Multibroadcast find_mul_conv #1384
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This build is not recommended to merge 🔴 |
umangyadav
reviewed
Sep 14, 2022
CharlieL7
commented
Sep 14, 2022
umangyadav
reviewed
Sep 15, 2022
umangyadav
reviewed
Sep 15, 2022
umangyadav
reviewed
Sep 15, 2022
umangyadav
reviewed
Sep 15, 2022
umangyadav
reviewed
Sep 15, 2022
umangyadav
approved these changes
Sep 15, 2022
pfultz2
reviewed
Sep 17, 2022
src/simplify_algebra.cpp
Outdated
| { | ||
| if(invalid_sl(i)) | ||
| invalid_case = true; | ||
| } |
There was a problem hiding this comment.
It would be simpler to write this as:
auto is_broadcasted_axis = [](auto len, auto stride) {
return len == 1 or stride == 0;
};
if (not is_broadcasted_axis(a_lens.front(), a_strides.front()))
return;
if (not std::equal(a_lens.begin()+2, a_lens.end(), a_strides.begin()+2, a_strides.end(), is_broadcasted_axis))
return;
pfultz2
reviewed
Sep 17, 2022
src/simplify_algebra.cpp
Outdated
|
|
||
| // check broadcasted along channels | ||
| auto a_lens = a_ins->get_shape().lens(); | ||
| auto a_strides = a_ins->get_shape().strides(); |
There was a problem hiding this comment.
These should be const auto&.
pfultz2
reviewed
Sep 17, 2022
src/simplify_algebra.cpp
Outdated
| invalid_case = true; | ||
| } | ||
|
|
||
| if(invalid_sl(0) or a_strides.at(1) != 1 or invalid_case) |
There was a problem hiding this comment.
You should check a_strides.at(1) != 1 before checking the broadcasted axis. Also, we should probably check the rank as well(ie a_lens.size() > 2) before we start checking everything else.
There was a problem hiding this comment.
Shouldn't rank >= 4 to be a valid convolution output?
pfultz2
approved these changes
Sep 20, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change find_mul_conv to work with multibroadcast also. Checks the strides instead of the broadcast axis.