Skip to content

[ROCm] Disable TestDataParallelDeviceType tests #1014

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

jaglinux
Copy link

@jaglinux jaglinux commented May 19, 2022

Skips test as per https://ontrack-internal.amd.com/browse/SWDEV-327377
distributed/test_data_parallel test suite fails, disabling these tests will make the suite pass.
The issue is currently under debug.

Signed-off-by: Jagadish Krishnamoorthy [email protected]

@jaglinux jaglinux requested a review from pruthvistony May 19, 2022 06:00
@jithunnair-amd
Copy link
Collaborator

@jaglinux As a general rule, please make sure to mention what error/failure signature are being observed for the tests being disabled, and any other details of the failure (or a link to the relevant JIRA). This helps gather some context when tracing back why and which ROCm etc. certain tests were disabled for.

@pruthvistony pruthvistony merged commit e88d29c into ROCm:rocm5.2_internal_testing May 19, 2022
Copy link
Collaborator

@pruthvistony pruthvistony left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants