Fix baseurl link in CentOS for ROCm5.2 #1031
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jithunnair-amd
pushed a commit
that referenced
this pull request
Jul 12, 2022
Co-authored-by: Wang, Yanyao <[email protected]>
jithunnair-amd
pushed a commit
that referenced
this pull request
Aug 30, 2022
Co-authored-by: Wang, Yanyao <[email protected]>
pruthvistony
pushed a commit
that referenced
this pull request
Nov 10, 2022
Co-authored-by: Wang, Yanyao <[email protected]>
akashveramd
pushed a commit
that referenced
this pull request
Jun 13, 2025
… now that it's supported in core (#1031) ## Summary In pytorch#149876 I found there was a problem with per op SAC, per layer SAC, and no AC because all these settings saved reduce_scatter_tensor for backward but this a problem: it broke the async TP pattern matching which expects reduce scatter node to only have 1 user (wait_tensor), not 2 (wait_tensor and output_node). In pytorch#149946 I addressed this by: 1) Adding new graph patterns to match on which allow reduce_scatter to have 2 users. 2) Updating the subgraph replacement logic to save the "fused matmul reduce scatter" node for backward instead of the reduce scatter node, if it detects the graph is saving reduce_scatter for backward. This allows the original matmul reduce scatter graph to be replaced and erased correctly. Once pytorch#149946 is landed, we can add back reduce_scatter_tensor to the op save list for SAC in torchtitan, and it won't break SAC and no AC anymore 👍
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #ISSUE_NUMBER