Fix test_Conv2d_groups related errors (SWDEV-416489) #1269
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is due to incorrect atol/rtol settings for torch.half and torch.bfloat16 data types.
xinyazhang
force-pushed
the
xinyazhang/fix-test_Conv2d_groups
branch
from
8e038f9 to
b47b956
Compare
|
The change is generic, doesnt affect CUDA is it? |
|
This change is generic and also applies to CUDA. However the question about CUDA is how can it achieve |
jithunnair-amd
approved these changes
Aug 18, 2023
There was a problem hiding this comment.
@xinyazhang Let's still gather the MIOpenDriver configs so we can file an MIOpen ticket. Whether it gets fixed in ROCm5.7 is up to them and Release Management. Meanwhile, merging this PR as a workaround.
pruthvistony
pushed a commit
that referenced
this pull request
Sep 11, 2023
* Fix test_Conv2d_groups related errors (SWDEV-416489) This is due to incorrect atol/rtol settings for torch.half and torch.bfloat16 data types. * More adjustment on Navi 32
dnikolaev-amd
pushed a commit
that referenced
this pull request
Sep 11, 2023
* Fix test_Conv2d_groups related errors (SWDEV-416489) This is due to incorrect atol/rtol settings for torch.half and torch.bfloat16 data types. * More adjustment on Navi 32
jithunnair-amd
pushed a commit
that referenced
this pull request
Sep 12, 2023
* Fix test_Conv2d_groups related errors (SWDEV-416489) This is due to incorrect atol/rtol settings for torch.half and torch.bfloat16 data types. * More adjustment on Navi 32 Co-authored-by: Xinya Zhang <[email protected]>
dnikolaev-amd
pushed a commit
that referenced
this pull request
Sep 21, 2023
* Fix test_Conv2d_groups related errors (SWDEV-416489) This is due to incorrect atol/rtol settings for torch.half and torch.bfloat16 data types. * More adjustment on Navi 32
pruthvistony
pushed a commit
that referenced
this pull request
Dec 6, 2023
* Fix test_Conv2d_groups related errors (SWDEV-416489) This is due to incorrect atol/rtol settings for torch.half and torch.bfloat16 data types. * More adjustment on Navi 32
dnikolaev-amd
pushed a commit
that referenced
this pull request
Dec 22, 2023
* Fix test_Conv2d_groups related errors (SWDEV-416489) This is due to incorrect atol/rtol settings for torch.half and torch.bfloat16 data types. * More adjustment on Navi 32
dnikolaev-amd
pushed a commit
that referenced
this pull request
Jan 9, 2024
* Fix test_Conv2d_groups related errors (SWDEV-416489) This is due to incorrect atol/rtol settings for torch.half and torch.bfloat16 data types. * More adjustment on Navi 32
pruthvistony
pushed a commit
that referenced
this pull request
Jan 10, 2024
* Fix test_Conv2d_groups related errors (SWDEV-416489) This is due to incorrect atol/rtol settings for torch.half and torch.bfloat16 data types. * More adjustment on Navi 32 Co-authored-by: Xinya Zhang <[email protected]>
pruthvistony
pushed a commit
that referenced
this pull request
Jan 21, 2024
* Fix test_Conv2d_groups related errors (SWDEV-416489) This is due to incorrect atol/rtol settings for torch.half and torch.bfloat16 data types. * More adjustment on Navi 32
pruthvistony
pushed a commit
that referenced
this pull request
Jan 22, 2024
* Fix test_Conv2d_groups related errors (SWDEV-416489) This is due to incorrect atol/rtol settings for torch.half and torch.bfloat16 data types. * More adjustment on Navi 32
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is due to incorrect atol/rtol settings for torch.half and torch.bfloat16 data types.
Fixes #SWDEV-416500