Skip to content

After the elementwise fix, these tests don't hang any longer. #130

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 17, 2018
Merged

After the elementwise fix, these tests don't hang any longer. #130

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
772427e
After the elementwise fix, these tests don't hang any longer.
iotamudelta Aug 16, 2018
66d224d
This fails on the CI.
iotamudelta Aug 16, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 0 additions & 7 deletions test/test_optim.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -236,7 +236,6 @@ def _build_params_dict(self, weight, bias, **kwargs):
def _build_params_dict_single(self, weight, bias, **kwargs):
return [dict(params=bias, **kwargs)]

@skipIfRocm
def test_sgd(self):
self._test_rosenbrock(
lambda params: optim.SGD(params, lr=1e-3),
Expand Down Expand Up @@ -273,7 +272,6 @@ def test_sgd_sparse(self):
lambda params: optim.SGD(params, lr=5e-3)
)

@skipIfRocm
def test_adam(self):
self._test_rosenbrock(
lambda params: optim.Adam(params, lr=1e-2),
Expand Down Expand Up @@ -311,7 +309,6 @@ def test_sparse_adam(self):
with self.assertRaisesRegex(ValueError, "Invalid beta parameter at index 0: 1.0"):
optim.SparseAdam(None, lr=1e-2, betas=(1.0, 0.0))

@skipIfRocm
def test_adadelta(self):
self._test_rosenbrock(
lambda params: optim.Adadelta(params),
Expand All @@ -335,7 +332,6 @@ def test_adadelta(self):
with self.assertRaisesRegex(ValueError, "Invalid rho value: 1.1"):
optim.Adadelta(None, lr=1e-2, rho=1.1)

@skipIfRocm
def test_adagrad(self):
self._test_rosenbrock(
lambda params: optim.Adagrad(params, lr=1e-1),
Expand Down Expand Up @@ -394,7 +390,6 @@ def test_adamax(self):
with self.assertRaisesRegex(ValueError, "Invalid beta parameter at index 1: 1.0"):
optim.Adamax(None, lr=1e-2, betas=(0.0, 1.0))

@skipIfRocm
def test_rmsprop(self):
self._test_rosenbrock(
lambda params: optim.RMSprop(params, lr=1e-2),
Expand All @@ -419,7 +414,6 @@ def test_rmsprop(self):
with self.assertRaisesRegex(ValueError, "Invalid momentum value: -1.0"):
optim.RMSprop(None, lr=1e-2, momentum=-1.0)

@skipIfRocm
def test_asgd(self):
self._test_rosenbrock(
lambda params: optim.ASGD(params, lr=1e-3),
Expand Down Expand Up @@ -469,7 +463,6 @@ def test_rprop(self):
with self.assertRaisesRegex(ValueError, "Invalid eta values: 1.0, 0.5"):
optim.Rprop(None, lr=1e-2, etas=(1.0, 0.5))

@skipIfRocm
def test_lbfgs(self):
self._test_rosenbrock(
lambda params: optim.LBFGS(params),
Expand Down