Skip to content

Skip ddp apply_optim_in_bwd tests for gloo #1302

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 27, 2023
Merged

Skip ddp apply_optim_in_bwd tests for gloo #1302

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 9 additions & 1 deletion torch/testing/_internal/distributed/distributed_test.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5066,7 +5066,11 @@ def _test_ddp_apply_optim_in_backward(
# set_to_none for regular optimizer to match in backward
# case.
optim.zero_grad(set_to_none=True)


@skip_but_pass_in_sandcastle_if(
BACKEND == "gloo" and HAS_TORCHVISION,
"Failing with gloo backend + torchvision due to ongoing issue https://github.com/pytorch/pytorch/issues/111834",
)
@skip_if_lt_x_gpu(2)
def test_ddp_apply_optim_in_backward(self):
for optim_cls, init_before in itertools.product(
Expand All @@ -5079,6 +5083,10 @@ def test_ddp_apply_optim_in_backward(self):
init_before=init_before,
)

@skip_but_pass_in_sandcastle_if(
BACKEND == "gloo" and HAS_TORCHVISION,
"Failing with gloo backend + torchvision due to ongoing issue https://github.com/pytorch/pytorch/issues/111834",
)
@skip_if_lt_x_gpu(2)
def test_ddp_apply_optim_in_backward_grad_as_bucket_view_false(self):
for init_before in [True, False]:
Expand Down