Skip to content

For ROCm builds, use the LD.Gold linker. #143

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

For ROCm builds, use the LD.Gold linker. #143

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions docker/caffe2/jenkins/common/install_rocm.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -73,6 +73,9 @@ else
exit 1
fi

# Enable the usage of LD.Gold for linking.
ln -s `which gold` /usr/bin/ld
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The more "official" way to do this is to use update-alternatives to set ld to a different implementation. There are a few examples of this in the jenkins docker configs already.

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This approach will also fail since /usr/bin/ld exists.


install_hip_thrust
install_rocrand
install_hcsparse