Skip to content

[release/2.1] fix test_vmapvjpvjp and skip test_profiler_experimental_tree #1444

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 27, 2024
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions test/functorch/test_ops.py
Original file line number Diff line number Diff line change
@@ -829,6 +829,8 @@ def fn(inp, *args, **kwargs):
{torch.float32: tol(atol=2e-03, rtol=2e-02)}),
tol1('svd',
{torch.float32: tol(atol=1e-03, rtol=5e-04)}),
tol1('linalg.householder_product',
{torch.float32: tol(atol=5e-04, rtol=5e-04)}),
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tolerance values inspired by

tol1('linalg.householder_product',

tol1('matrix_exp',
{torch.float32: tol(atol=1e-03, rtol=5e-04)}),
))
4 changes: 3 additions & 1 deletion test/profiler/test_profiler_tree.py
Original file line number Diff line number Diff line change
@@ -12,7 +12,7 @@
import torch
from torch._C._profiler import _ExtraFields_PyCall, _ExtraFields_PyCCall
from torch.testing._internal.common_utils import (
TestCase, run_tests, IS_WINDOWS, TEST_WITH_CROSSREF, IS_ARM64)
skipIfRocm, TestCase, run_tests, IS_WINDOWS, TEST_WITH_CROSSREF, IS_ARM64)
from torch.utils._pytree import tree_map

# These functions can vary from based on platform and build (e.g. with CUDA)
@@ -249,6 +249,7 @@ def assertTreesMatch(self, actual: str, expected: str, allow_failure: bool = Fal
else:
raise

@skipIfRocm
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Skipping for now, proper fix to be done in https://github.com/ROCm/frameworks-internal/issues/8556

@ProfilerTree.test
def test_profiler_experimental_tree(self):
t1, t2 = torch.ones(1, requires_grad=True), torch.ones(1, requires_grad=True)
@@ -348,6 +349,7 @@ def test_profiler_experimental_tree_with_record_function(self):
aten::copy_"""
)

@skipIfRocm
@ProfilerTree.test
def test_profiler_experimental_tree_with_memory(self):
t1, t2 = torch.ones(1, requires_grad=True), torch.ones(1, requires_grad=True)