[UPCP][release/2.4] TunableOp fix for batched MM with views. #1723
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes pytorch#140278 Pull Request resolved: pytorch#140673 Approved by: https://github.com/jeffdaily
pruthvistony
changed the title
pruthvistony
approved these changes
Nov 15, 2024
jithunnair-amd
pushed a commit
that referenced
this pull request
Mar 17, 2025
Fixes pytorch#140278 Based on PR: pytorch#140673 Note in test/linalg.py that I had to include Case #4 from upstream in addition to Case #5 to resolve the merge conflict from the cherry-pick of the upstream commit. Verified manually that test_bmm_tunableop_rocm UT passes. cc: @jeffdaily
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes pytorch#140278
Based on PR:
pytorch#140673
Note in test/linalg.py that I had to include Case #4 from upstream in addition to Case #5 to resolve the merge conflict from the cherry-pick of the upstream commit.
Verified manually that test_bmm_tunableop_rocm UT passes.
cc: @jeffdaily