Skip to content

[rocm6.4_internal_testing] [NAVI32] Skipped sdpa_2 test in test_aot_inductor for Navi32 #1882

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 19, 2025
Merged

[rocm6.4_internal_testing] [NAVI32] Skipped sdpa_2 test in test_aot_inductor for Navi32 #1882

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions test/inductor/test_aot_inductor.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,8 +44,10 @@
IS_MACOS,
IS_WINDOWS,
skipIfRocm,
skipIfRocmArch,
skipIfXpu,
TEST_WITH_ROCM,
NAVI32_ARCH,
)
from torch.testing._internal.inductor_utils import GPU_TYPE
from torch.testing._internal.logging_utils import LoggingTestCase, make_logging_test
Expand Down Expand Up @@ -925,6 +927,8 @@ def forward(self, q, k, v):
)
self.check_model(Model(), example_inputs)

# Eager mode produces incorrect tensor values for navi32 during this test
@skipIfRocmArch(NAVI32_ARCH)
@unittest.skipIf(IS_FBCODE, "Not yet runnable in fbcode")
@unittest.skipIf(not SM80OrLater, "bfloat16 only supported in sm80+")
def test_sdpa_2(self):
Expand Down
2 changes: 2 additions & 0 deletions torch/testing/_internal/common_utils.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1360,6 +1360,8 @@ def printErrors(self) -> None:
IS_ARM64 = platform.machine() in ('arm64', 'aarch64')
IS_S390X = platform.machine() == "s390x"

NAVI32_ARCH = "gfx1101"

def is_navi_arch():
if torch.cuda.is_available():
prop = torch.cuda.get_device_properties(0)
Expand Down