Fix static_cast logic in hipify script for better coverage #20
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…solete code for output directory not existing
|
Thanks! Did you check if unit tests are running? |
|
As per the review for pytorch#8812 w/ upstream: could you add to the documentation of the function an example for before vs after? Thanks |
Jorghi12
reviewed
Jul 9, 2018
| the_type = argument_types[arg_idx] | ||
| the_arg = arg.replace("\n", "").strip() | ||
| the_arg = arg.replace("\n", "").replace("\\", "").strip() |
There was a problem hiding this comment.
There are instances where the kernel invocation is part of a preprocessor multiline macro. That's where the "\\" comes from (for the literal backslash used in a multiline macro).
|
LGTM after the recent documentation additions. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix static_cast logic in hipify script for better coverage
Also remove obsolete code for output directory not existing