Skip to content

[release/2.6] Change gfx110x BLAS preferred backend #2053

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: release/2.6
Choose a base branch
from

Conversation

amd-imilenko
Copy link

@amd-imilenko amd-imilenko commented Apr 25, 2025

Change gfx110x BLAS preferred backend from hipBLASLt to rocBLAS.

@amd-imilenko amd-imilenko requested a review from jeffdaily April 25, 2025 14:28
@rocm-repo-management-api
Copy link

rocm-repo-management-api bot commented Apr 25, 2025

Jenkins build for d9b0d061725412951c47dce318dbf10d4823a297 commit finished as FAILURE
Links: Blue Ocean view / Build artifacts

@rocm-repo-management-api
Copy link

Jenkins build for d9b0d061725412951c47dce318dbf10d4823a297 commit is in progress
Links: Blue Ocean view / Build artifacts

@rocm-repo-management-api
Copy link

rocm-repo-management-api bot commented Apr 28, 2025

Jenkins build for d9b0d061725412951c47dce318dbf10d4823a297 commit finished as FAILURE
Links: Blue Ocean view / Build artifacts

@jeffdaily
Copy link
Collaborator

For upstream release/2.7 we applied this patch which adds a Default blas backend which then becomes cublas or cublaslt. pytorch#150212

For release/2.6, it should be as straightforward as this diff:

diff --git a/aten/src/ATen/Context.cpp b/aten/src/ATen/Context.cpp
index a0e3b3d638..fbdbe767e3 100644
--- a/aten/src/ATen/Context.cpp
+++ b/aten/src/ATen/Context.cpp
@@ -320,7 +320,7 @@ at::BlasBackend Context::blasPreferredBackend() {
       static const std::vector<std::string> archs = {
           "gfx90a", "gfx942"
 #if ROCM_VERSION >= 60300
-          , "gfx1100", "gfx1101", "gfx1200", "gfx1201"
+          , "gfx1200", "gfx1201"
 #endif
 #if ROCM_VERSION >= 60500
           , "gfx950"

@rocm-repo-management-api
Copy link

rocm-repo-management-api bot commented Apr 28, 2025

Jenkins build for d9b0d061725412951c47dce318dbf10d4823a297 commit finished as FAILURE
Links: Blue Ocean view / Build artifacts

@rocm-repo-management-api
Copy link

rocm-repo-management-api bot commented Apr 30, 2025

Jenkins build for d9b0d061725412951c47dce318dbf10d4823a297 commit finished as FAILURE
Links: Blue Ocean view / Build artifacts

@rocm-repo-management-api
Copy link

rocm-repo-management-api bot commented Apr 30, 2025

Jenkins build for d9b0d061725412951c47dce318dbf10d4823a297 commit finished as FAILURE
Links: Blue Ocean view / Build artifacts

@rocm-repo-management-api
Copy link

rocm-repo-management-api bot commented Apr 30, 2025

Jenkins build for d9b0d061725412951c47dce318dbf10d4823a297 commit finished as ABORTED
Links: Blue Ocean view / Build artifacts

@rocm-repo-management-api
Copy link

rocm-repo-management-api bot commented Apr 30, 2025

Jenkins build for d9b0d061725412951c47dce318dbf10d4823a297 commit finished as FAILURE
Links: Blue Ocean view / Build artifacts

@rocm-repo-management-api
Copy link

rocm-repo-management-api bot commented Apr 30, 2025

Jenkins build for d9b0d061725412951c47dce318dbf10d4823a297 commit finished as FAILURE
Links: Blue Ocean view / Build artifacts

@rocm-repo-management-api
Copy link

rocm-repo-management-api bot commented May 2, 2025

Jenkins build for d9b0d061725412951c47dce318dbf10d4823a297 commit finished as FAILURE
Links: Blue Ocean view / Build artifacts

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants