Skip to content

enabled debug symbols for hipcc during debug build. #215

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Sep 21, 2018
Merged

enabled debug symbols for hipcc during debug build. #215

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
839a7c2
enabled debug symbols for hipcc
lcskrishna Sep 19, 2018
0167785
Merge branch 'master' into cl/debug-flags
lcskrishna Sep 20, 2018
0a63a19
changed HIP_HCC_FLAGS to HIP_HIPCC_FLAGS
lcskrishna Sep 21, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions cmake/Dependencies.cmake
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -549,6 +549,11 @@ if(NOT BUILD_ATEN_MOBILE)
list(APPEND HIP_HIPCC_FLAGS -Wno-shift-count-overflow)
list(APPEND HIP_HIPCC_FLAGS -Wno-unused-command-line-argument)
list(APPEND HIP_HIPCC_FLAGS -Wno-duplicate-decl-specifier)

if(CMAKE_BUILD_TYPE MATCHES Debug)
list(APPEND HIP_HIPCC_FLAGS -g)
list(APPEND HIP_HIPCC_FLAGS -O0)
endif(CMAKE_BUILD_TYPE MATCHES Debug)

set(Caffe2_HIP_INCLUDES
${hip_INCLUDE_DIRS} ${hcc_INCLUDE_DIRS} ${hsa_INCLUDE_DIRS} ${rocrand_INCLUDE_DIRS} ${hiprand_INCLUDE_DIRS} ${rocblas_INCLUDE_DIRS} ${miopen_INCLUDE_DIRS} ${thrust_INCLUDE_DIRS} $<INSTALL_INTERFACE:include> ${Caffe2_HIP_INCLUDES})
Expand Down