This repository was archived by the owner on Aug 10, 2020. It is now read-only.
Rename immutable.js to index.js so it can be found by Google Closure Compiler. #40
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
OK, never mind! I got instructions on how to make this work in GCC in this issue: google/closure-compiler#3163. Closing this PR. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi, I'm not sure if this is important to you but the Google Closure Compiler is lacking a feature to read the value for "main" in package.json. That means the compiler can't find your file "immutable.js" when people do something like
const extend = require('xtend');. It actually breaks some components in material-components-web (if the dev is using Google Closure Compiler).Up to you if you want to accept this PR, but if not I'll just keep this fork until the feature is added in Google Closure Compiler.