Accommodate NA behavior on arm64/aarch64 for Linux as well #1379
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Any objections to folding the arm-linux test out to an optional CI now that we know it works? I have that ready here, and I think I like that better. |
|
No objections. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1378
The linux-on-arm platform is still reasonably rare and hence not one that CRAN tests for, by r-universe now does and this revealed that the same 'NA does not propagate well' issue we accommodate for macos-on-arm already. This PR simply extends that treatmeant.
A new CI run has been added for linux-arm, it is by far the slowest so one open question is whether we should keep it for all runs. Maybe a simpler approach is to take it out of the matrix it is currently in but submit a new yaml file with just the 'workflow_dispatch' option so that we dial in when we want to. Thoughts?
Checklist
R CMD checkstill passes all tests