-
-
Notifications
You must be signed in to change notification settings - Fork 599
feat(YouTube Music): Add Theme
patch
#5984
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
If you want, add the other files to the project ignore file and include with this PR. |
extensions/youtube/src/main/java/app/revanced/extension/youtube/patches/theme/ThemePatch.java
Outdated
Show resolved
Hide resolved
5d5d2a6
to
cb57cc0
Compare
// Cannot use an option validator, because resources | ||
// have not been decoded when validator is called. | ||
val darkColor = darkColorReplacement() | ||
if (!validateColorName(darkColor)) { | ||
throw PatchException("Invalid dark theme color: $darkColor" | ||
) | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I tried changing this to an option validator because invalid app resources later throw an exception during resource compilation.
But it seems the validator feature is currently broken.
ReVanced/revanced-patcher#372
8768e6c
to
c62e2d5
Compare
Seems ready to merge? |
c62e2d5
to
ba12468
Compare
patches/src/main/kotlin/app/revanced/patches/music/layout/theme/ThemePatch.kt
Outdated
Show resolved
Hide resolved
patches/src/main/kotlin/app/revanced/patches/music/layout/theme/ThemePatch.kt
Outdated
Show resolved
Hide resolved
patches/src/main/kotlin/app/revanced/patches/shared/layout/theme/LithoColorHookPatch.kt
Show resolved
Hide resolved
patches/src/main/kotlin/app/revanced/patches/music/layout/navigationbar/NavigationBarPatch.kt
Show resolved
Hide resolved
patches/src/main/kotlin/app/revanced/patches/shared/layout/theme/Fingerprints.kt
Outdated
Show resolved
Hide resolved
…e/ThemePatch.kt Co-authored-by: oSumAtrIX <[email protected]>
patches/src/main/kotlin/app/revanced/patches/youtube/layout/theme/ThemePatch.kt
Outdated
Show resolved
Hide resolved
patches/src/main/kotlin/app/revanced/patches/youtube/layout/theme/ThemePatch.kt
Outdated
Show resolved
Hide resolved
I don’t really feel like making the branding and app name change patch anymore 😬, since it means dealing with those abstractions again. I’ll probably leave it to you or someone else who wants to do it (though I doubt anyone will want to) 😅. |
extensions/shared/library/src/main/java/app/revanced/extension/shared/theme/BaseThemePatch.java
Show resolved
Hide resolved
patches/src/main/kotlin/app/revanced/patches/shared/layout/theme/LithoColorHookPatch.kt
Show resolved
Hide resolved
patches/src/main/kotlin/app/revanced/patches/shared/layout/theme/Fingerprints.kt
Show resolved
Hide resolved
patches/src/main/kotlin/app/revanced/patches/youtube/layout/theme/ThemePatch.kt
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Apart from reviews, looking good
# [5.41.0-dev.16](v5.41.0-dev.15...v5.41.0-dev.16) (2025-09-26) ### Features * **YouTube Music:** Add `Theme` patch ([#5984](#5984)) ([3bd76d6](3bd76d6))
@MarcaDian, these shouldn't be black by the way. |
These elements are missing ids and descriptions, so it is probably obfuscated and I don't know how to change its color. |
# [5.41.0](v5.40.0...v5.41.0) (2025-09-27) ### Bug Fixes * **Instagram - Hide navigation buttons:** Remove button based on name ([#5971](#5971)) ([6fa4043](6fa4043)) * **Instagram - Limit feed to followed profiles:** Preserve favorites feed ([#5963](#5963)) ([ef51401](ef51401)) * **TikTok:** Show correct dialog restart text, use correct font color for non-dark mode ([d1a1293](d1a1293)) * **Twitch - Settings:** Fix missing style resources ([#5970](#5970)) ([8c22995](8c22995)) * **YouTube - Hide Shorts components:** Fix "Hide preview comment" ([#5990](#5990)) ([dd4e2cd](dd4e2cd)) * **YouTube - Return YouTube Dislike:** Do not show error toast if API returns 401 status ([#5949](#5949)) ([58d088a](58d088a)) * **YouTube - Settings:** Handle on screen back swipe gesture ([#6002](#6002)) ([6f92b6c](6f92b6c)) * **YouTube - Settings:** Use an overlay to show search results ([#5806](#5806)) ([ece8076](ece8076)) * **YouTube - SponsorBlock:** Show category color dot in voting dialog menu ([4be00d0](4be00d0)) * **YouTube - SponsorBlock:** Show category color in create new segment menu ([#5987](#5987)) ([ffd933c](ffd933c)) * **YouTube - Spoof video streams:** Update client side effects summary text ([a0a62dd](a0a62dd)) ### Features * **Tumblr:** Add `Disable Tumblr TV` patch ([#5959](#5959)) ([212418b](212418b)) * **YouTube - Hide layout components:** Add "Hide Emoji and Timestamp buttons" setting ([#5992](#5992)) ([2b555f6](2b555f6)) * **YouTube - Hide layout components:** Add "Hide view count" and "Hide upload time" settings ([#5983](#5983)) ([7a37d85](7a37d85)) * **YouTube - Loop video:** Add player button to change loop video state ([#5961](#5961)) ([dfb5407](dfb5407)) * **YouTube - Spoof app version:** Add spoof target `20.05.46` that fixes transcript functionality ([5823f0e](5823f0e)) * **YouTube Music:** Add `Check watch history domain name resolution` ([#5979](#5979)) ([8af70fe](8af70fe)) * **YouTube Music:** Add `Sanitize sharing links` patch ([#5952](#5952)) ([45c1ee8](45c1ee8)) * **YouTube Music:** Add `Theme` patch ([#5984](#5984)) ([3bd76d6](3bd76d6)) * **YouTube:** Add `Disable video codecs` patch ([#5981](#5981)) ([bfbffbd](bfbffbd))
Closes #609 #5814