Skip to content

Conversation

MarcaDian
Copy link
Contributor

Closes #609 #5814

@MarcaDian
Copy link
Contributor Author

Can someone add a couple more lines to .gitignore so that this garbage doesn't get into commits, it's always distracting and have to waste time unchecking things.

image

@LisoUseInAIKyrios
Copy link
Contributor

misc.xml is needed but it's always changing because gradle syncing will change it to whatever JDK is your IDE default.

If you want, add the other files to the project ignore file and include with this PR.

Comment on lines 109 to 115
// Cannot use an option validator, because resources
// have not been decoded when validator is called.
val darkColor = darkColorReplacement()
if (!validateColorName(darkColor)) {
throw PatchException("Invalid dark theme color: $darkColor"
)
}
Copy link
Contributor

@LisoUseInAIKyrios LisoUseInAIKyrios Sep 25, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tried changing this to an option validator because invalid app resources later throw an exception during resource compilation.

But it seems the validator feature is currently broken.
ReVanced/revanced-patcher#372

@LisoUseInAIKyrios
Copy link
Contributor

Seems ready to merge?

@oSumAtrIX oSumAtrIX self-requested a review September 25, 2025 10:04
@MarcaDian
Copy link
Contributor Author

I don’t really feel like making the branding and app name change patch anymore 😬, since it means dealing with those abstractions again. I’ll probably leave it to you or someone else who wants to do it (though I doubt anyone will want to) 😅.

Copy link
Member

@oSumAtrIX oSumAtrIX left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apart from reviews, looking good

@LisoUseInAIKyrios LisoUseInAIKyrios merged commit 3bd76d6 into ReVanced:dev Sep 26, 2025
1 check passed
github-actions bot pushed a commit that referenced this pull request Sep 26, 2025
# [5.41.0-dev.16](v5.41.0-dev.15...v5.41.0-dev.16) (2025-09-26)

### Features

* **YouTube Music:** Add `Theme` patch ([#5984](#5984)) ([3bd76d6](3bd76d6))
@MarcaDian MarcaDian deleted the music-theme branch September 26, 2025 06:54
@ILoveOpenSourceApplications
Copy link
Contributor

@MarcaDian, these shouldn't be black by the way.
484460959-0a3b6299-272d-4677-9088-01f2916c4f59

@LisoUseInAIKyrios LisoUseInAIKyrios linked an issue Sep 26, 2025 that may be closed by this pull request
3 tasks
@MarcaDian
Copy link
Contributor Author

MarcaDian commented Sep 26, 2025

               └── FrameLayout (id: browse_content) [0,226][1080,2224]
                   └── LinearLayout (id: tabbed_view_container) [0,226][1080,2224]
                       └── LinearLayout (id: tabbed_view) [0,226][1080,2224]
                           └── ViewPager [0,226][1080,2224]
                               └── ViewGroup [0,226][1080,2224]
                                   └── RecyclerView (id: section_list_content, scrollable) [0,226][1080,2224]
                                       ├── ViewGroup [0,226][1080,644] (Section 1)
                                       │   ├── ViewGroup (clickable) [55,270][349,556]
                                       │   ├── ViewGroup (clickable) [393,270][687,556]
                                       │   └── ViewGroup (clickable) [731,270][1025,556]
Section 1 [0,226][1080,644]
├── Tile 1 (clickable) [55,270][349,556]
│   └── ImageView [88,303][143,358] (55x55 px)
├── Tile 2 (clickable) [393,270][687,556]
│   └── ImageView [426,303][481,358] (55x55 px)
└── Tile 3 (clickable) [731,270][1025,556]
    └── ImageView [764,303][819,358] (55x55 px)

These elements are missing ids and descriptions, so it is probably obfuscated and I don't know how to change its color.

github-actions bot pushed a commit that referenced this pull request Sep 27, 2025
# [5.41.0](v5.40.0...v5.41.0) (2025-09-27)

### Bug Fixes

* **Instagram - Hide navigation buttons:** Remove button based on name ([#5971](#5971)) ([6fa4043](6fa4043))
* **Instagram - Limit feed to followed profiles:** Preserve favorites feed ([#5963](#5963)) ([ef51401](ef51401))
* **TikTok:** Show correct dialog restart text, use correct font color for non-dark mode ([d1a1293](d1a1293))
* **Twitch - Settings:** Fix missing style resources ([#5970](#5970)) ([8c22995](8c22995))
* **YouTube - Hide Shorts components:** Fix "Hide preview comment" ([#5990](#5990)) ([dd4e2cd](dd4e2cd))
* **YouTube - Return YouTube Dislike:** Do not show error toast if API returns 401 status ([#5949](#5949)) ([58d088a](58d088a))
* **YouTube - Settings:** Handle on screen back swipe gesture ([#6002](#6002)) ([6f92b6c](6f92b6c))
* **YouTube - Settings:** Use an overlay to show search results ([#5806](#5806)) ([ece8076](ece8076))
* **YouTube - SponsorBlock:** Show category color dot in voting dialog menu ([4be00d0](4be00d0))
* **YouTube - SponsorBlock:** Show category color in create new segment menu ([#5987](#5987)) ([ffd933c](ffd933c))
* **YouTube - Spoof video streams:** Update client side effects summary text ([a0a62dd](a0a62dd))

### Features

* **Tumblr:** Add `Disable Tumblr TV` patch ([#5959](#5959)) ([212418b](212418b))
* **YouTube - Hide layout components:** Add "Hide Emoji and Timestamp buttons" setting ([#5992](#5992)) ([2b555f6](2b555f6))
* **YouTube - Hide layout components:** Add "Hide view count" and "Hide upload time" settings ([#5983](#5983)) ([7a37d85](7a37d85))
* **YouTube - Loop video:** Add player button to change loop video state ([#5961](#5961)) ([dfb5407](dfb5407))
* **YouTube - Spoof app version:** Add spoof target `20.05.46` that fixes transcript functionality ([5823f0e](5823f0e))
* **YouTube Music:** Add `Check watch history domain name resolution` ([#5979](#5979)) ([8af70fe](8af70fe))
* **YouTube Music:** Add `Sanitize sharing links` patch ([#5952](#5952)) ([45c1ee8](45c1ee8))
* **YouTube Music:** Add `Theme` patch ([#5984](#5984)) ([3bd76d6](3bd76d6))
* **YouTube:** Add `Disable video codecs` patch ([#5981](#5981)) ([bfbffbd](bfbffbd))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

feat: Call all "AMOLED themes" black themes feat(YouTube Music): Black theme for cast pop-up panel feat(YouTube Music): Theme patch

4 participants