-
-
Notifications
You must be signed in to change notification settings - Fork 533
[BUG] Single test fails #1083
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
3b411f0 is the offending commit |
Any traction on this? |
@kevcenteno we're planning on overhauling the test suites soon, since there's been issues with inconsistency not just with this one. Until then, if you think of any easy fixes for this one, we'd really appreciate suggestions or even a PR. |
This issue is stale because it has not seen activity in 30 days. Remove the |
Working on some test refactoring on #1171. Everything seems to be working now. For future reference, when testing the tooltip NOT to be on screen, we recommend the following (using await waitFor(() => {
expect(screen.queryByRole('tooltip')).not.toBeInTheDocument()
}) When getting a reference to the tooltip, we recommend this: const tooltip = await screen.findByRole('tooltip')
expect(tooltip).toHaveAttribute('style') Waiting for the tooltip to have the await waitFor(() => {
// also useful with `react-tooltip__closing`
expect(screen.queryByRole('tooltip')).toHaveClass('react-tooltip__show')
}) Will be closing this for now. Please open a new issue if you have further problems with writing tests for the tooltip. The internal tooltip tests should all pass after #1171 is merged. |
Uh oh!
There was an error while loading. Please reload this page.
Bug description
Test suites with only one test fail.
Version of Package
v5.21.1 but behaviour first seen in v5.20.0
To Reproduce
Delete all tests in
src/test/tooltip-props.spec.js
except for "basic tooltip". Update snapshots to reduce noise.OR
Replace
test
withtest.only
instead of deleting all the other tests.Test run results in failure:
Expected behavior
Test should pass
Desktop (please complete the following information if possible or delete this section):
The text was updated successfully, but these errors were encountered: