Skip to content

Using rollup for building the project, and modifying example #530

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jan 31, 2020

Conversation

roggervalf
Copy link
Contributor

Hi @wwayne,
I refactored how to build the project by using rollup. So first run the script yarn build. If you would like to try the example, enter into example folder and run yarn to install the dependencies; I add a link to the actual package and the run yarn start. I would like to be a maintainer. I already use this package into one of my packages. https://www.npmjs.com/settings/rogger.794/packages.
I opened for feedbacks.

@aronhelser
Copy link
Collaborator

Hi @Rogger794 , thanks for your interest! I think it would be great to have you help maintain the project, sorry I haven't had time to look yet.

@aronhelser
Copy link
Collaborator

Can you look at Travis and see what the CI should run?

@roggervalf
Copy link
Contributor Author

Hi @aronhelser
I already changed travis to use yarn and use rollup build.

@aronhelser
Copy link
Collaborator

@Rogger794 I'm sorry I let this sit. Would you take a look at #536 and see what you think of this alternate build method? I am open to either way, but I am not familiar with rollup.

@aronhelser
Copy link
Collaborator

@wwayne for some reason I can't access the 'settings' tab of this repo to give @Rogger794 any permissions. Would you be willing to add them as a maintainer?

@aronhelser aronhelser merged commit 08289a8 into ReactTooltip:master Jan 31, 2020
@wwayne
Copy link
Collaborator

wwayne commented Jan 31, 2020

🎉 This PR is included in version 3.11.3 🎉

The release is available on:

Your semantic-release bot 📦🚀

@tkalliom
Copy link

tkalliom commented Feb 3, 2020

Commenting here to potentially help someone with the same problem.

After patch-level updates to dependencies, TypeScript transpilation of an app failed with "export 'rebuild' (imported as 'ReactTooltip') was not found in 'react-tooltip'. This change introduces EcmaScript module exports, so old, CommonJS style imports need to be changed.

It would make sense to mention a change like this in the release notes. Even a minor version change, as opposed to patch version, might be warranted. At the time of writing, @types/react-tooltip has not been updated accordingly.

@wwayne
Copy link
Collaborator

wwayne commented Feb 3, 2020

@aronhelser Sorry just saw your comment, I just added @Rogger794 into the collaborators, thank you both :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants