Skip to content

fix: effect and type not properly applied at first render #735

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 31, 2022
Merged

fix: effect and type not properly applied at first render #735

merged 1 commit into from
Jan 31, 2022

Conversation

KazuAlex
Copy link
Contributor

Fix incorrect color scheme when use type != "dark" at first render
Same with effect different from "float"

Fix #731

@KazuAlex
Copy link
Contributor Author

Hi @aronhelser @roggervalf
Could you take a look please ? :)

@aronhelser aronhelser merged commit 8d260dc into ReactTooltip:master Jan 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@whiteadi whiteadi whiteadi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Thema/Type is not applied at first render, default dark is set even if the type prop is light
3 participants
@KazuAlex @whiteadi @aronhelser