Skip to content

chore: dependencies upgrade #799

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 10 commits into from
Oct 13, 2022
Merged

chore: dependencies upgrade #799

merged 10 commits into from
Oct 13, 2022

Conversation

danielbarion
Copy link
Member

Upgrading dependencies and some informations of the project (like maintainers and the new repo structure inside ReactTooltip)

@danielbarion danielbarion force-pushed the chore/dependencies-upgrade branch from 2082075 to 8d71cd4 Compare October 13, 2022 14:18
@aronhelser
Copy link
Collaborator

Another thing to think about is the demo webpage - it was on github-pages but looks like it's nuked somehow.

@danielbarion danielbarion marked this pull request as draft October 13, 2022 14:50
@danielbarion
Copy link
Member Author

Oh, I'll check as soon as possible @aronhelser, thanks for realizing that!

That PR is still in draft, I'm updating the major dependencies and testing after each package gets upgraded, so, that PR will take a few more hours/days to get ready to go.

@aronhelser
Copy link
Collaborator

Looks fine so far...

@danielbarion
Copy link
Member Author

danielbarion commented Oct 13, 2022

One question: I never did a GitHub page from an organization, just from personal GitHub account, so, maybe we need to consider using some tool like Netlify to show the demo page as static assets, right?

I've added Netlify to the ReactTooltip organization, but nervermind.

Solved, I'll update the Readme. https://reacttooltip.github.io/react-tooltip/

hey, @pdeszynski I've added you to the readme as a maintainer, please feel free to update your current status.

@danielbarion
Copy link
Member Author

@aronhelser, as that PR contains a fix aae936e and docs update, like the demo page, I'll stop the dependency upgrades here and I'll do another PR for the others that need to be upgraded, please, feel free to review and merge that PR when you can.

Thanks!

@danielbarion danielbarion marked this pull request as ready for review October 13, 2022 15:33
@aronhelser
Copy link
Collaborator

I'll leave it to you to merge when you are ready.
LGTM, +1

@danielbarion danielbarion merged commit 2bbfc7c into master Oct 13, 2022
@danielbarion danielbarion deleted the chore/dependencies-upgrade branch October 13, 2022 17:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants