Skip to content

Add positionStrategy prop #841

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Dec 8, 2022
Merged

Add positionStrategy prop #841

merged 2 commits into from
Dec 8, 2022

Conversation

gabrieljablonski
Copy link
Member

Closes #840.

@gabrieljablonski
Copy link
Member Author

Any idea why this check started failing? Thought it was an issue with my environment, no idea why it suddenly started happening.

Adding and setting up eslint-import-resolver-typescript solves it. If that's ok, I can push the changes.

@danielbarion
Copy link
Member

danielbarion commented Dec 8, 2022

Yeah, this was weird, I'm checking your PR locally. I had to stop because of my work, but I'll check as soon as possible to confirm.

Also, thank you so much for the reports and for the PRs!

Quick question: why you removed the import type (type) from import? - I'm just asking because I don't know the side-effect of using or not using type when importing decorators.

And I'm already building the types, how can I improve this? The types are working on a study project that I have.

@gabrieljablonski
Copy link
Member Author

gabrieljablonski commented Dec 8, 2022

why you removed the import type (type) from import?

Oh, this is definitely the issue. Wasn't intentional, I'll revert it.
Basically import type gets completely erased after transpilation, so it doesn't show up at runtime. The issue with eslint is probably because I was trying to just import a .d.ts file, but not exactly sure if that's the whole reason.

@danielbarion
Copy link
Member

Oh, this was the issue hahaha

Thanks @gabrieljablonski, merged 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] Clipping when parent container has position: relative and overflow: hidden
2 participants