Skip to content

feat: dynamically setting style through styles prop #846

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 22 commits into from
Dec 10, 2022
Merged

feat: dynamically setting style through styles prop #846

merged 22 commits into from
Dec 10, 2022

Conversation

danielbarion
Copy link
Member

@danielbarion danielbarion commented Dec 8, 2022 •
edited
Loading

  • now tooltip arrow inherits the background color from the tooltip
  • now it's possible to pass inline styling to the tooltip
  • docs updated
  • contribution.md added into the project with steps to run the project locally
  • gabrieljablonski added as maintainer of the project
  • typescript decorators now are exported to dist folder as expected

closes #843
closes #839

danielbarion
danielbarion commented Dec 8, 2022
View reviewed changes
@danielbarion danielbarion self-assigned this Dec 8, 2022
@danielbarion
Copy link
Member Author

When this PR gets merged, we will need a new release because docs will be automatically updated.

@danielbarion danielbarion marked this pull request as ready for review December 8, 2022 20:08
gabrieljablonski
gabrieljablonski requested changes Dec 9, 2022
View reviewed changes
gabrieljablonski
gabrieljablonski approved these changes Dec 9, 2022
View reviewed changes
Copy link
Member

@gabrieljablonski gabrieljablonski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@danielbarion danielbarion merged commit ce760c2 into master Dec 10, 2022
@danielbarion danielbarion deleted the feat/style-prop branch December 10, 2022 12:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gabrieljablonski gabrieljablonski gabrieljablonski approved these changes

Assignees

@danielbarion danielbarion

Labels
Enhancement Feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[FEAT REQ] Dynamically setting style [BUG] Types not available on the npm package
2 participants
@danielbarion @gabrieljablonski