fix: wrapper element changing after first render #935
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danielbarion
commented
Feb 3, 2023
| @@ -38,7 +38,7 @@ const Tooltip = ({ | |||
| setIsOpen, | |||
| }: ITooltip) => { | |||
| const tooltipRef = useRef<HTMLElement>(null) | |||
| const tooltipArrowRef = useRef<HTMLDivElement>(null) | |||
There was a problem hiding this comment.
updated to match other possible elements
| @@ -19,7 +19,7 @@ const Tooltip = ({ | |||
| events = ['hover'], | |||
| positionStrategy = 'absolute', | |||
| middlewares, | |||
| wrapper: WrapperElement = 'div', | |||
There was a problem hiding this comment.
default value removed because there's no way to use Tooltip component directly without Controller and Controller always passes a wrapper to Tooltip
| @@ -43,7 +43,7 @@ export interface ITooltip { | |||
| id?: string | |||
| variant?: VariantType | |||
| anchorId?: string | |||
| wrapper?: WrapperType | |||
There was a problem hiding this comment.
possible undefined removed because there's no way to use Tooltip component directly without Controller and Controller always passes a wrapper to Tooltip
| @@ -85,7 +85,7 @@ const TooltipController = ({ | |||
| setTooltipOffset(value === null ? offset : Number(value)) | |||
| }, | |||
| wrapper: (value) => { | |||
| setTooltipWrapper((value as WrapperType) ?? 'div') | |||
There was a problem hiding this comment.
the fix.
when the component start to check anchor attributes and there's no wrapper, the wrapper state gets updated to be a div
gabrieljablonski
approved these changes
Feb 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
close #929