Skip to content

Remove floating-ui exports to improve bundlesize #957

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Feb 22, 2023

Conversation

gabrieljablonski
Copy link
Member

We don't even have it on the documentation that you can import the middlewares directly from the package.
If needed, the middlewares can be imported directly from @floating-ui/dom.

Copy link
Member

@danielbarion danielbarion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It makes sense to me, thanks!

@gabrieljablonski gabrieljablonski merged commit fb62cbf into master Feb 22, 2023
@gabrieljablonski gabrieljablonski deleted the fix/remove-floating-ui-exports branch February 22, 2023 15:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants