Add external deps rollup plugin #958
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gabrieljablonski
force-pushed
the
build/peer-deps-external
branch
from
0779f63 to
73aae4f
Compare
|
When I did a quick test for this change, the package got broken, unsure if the reason was a bug or package misconfiguration. Was this tested? I propose to we release a beta version to be sure this will work as expected. |
|
The Esbuild PR: #959 |
|
Using esbuild instead #959 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding the plugin without with default configurations seems to work fine.
Is there a reason we shouldn't do this?
Sample project: https://stackblitz.com/edit/react-ts-22ya1r?file=App.tsx,package.json
Bundlephobia: https://bundlephobia.com/package/[email protected]