Remove incorrect react-responsive comparison #124
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I've been seeing [this comment](#70 (comment)) circulate recently, which is incorrect. react-responsive supports render functions just fine ([documented here](https://github.com/contra/react-responsive#rendering-with-a-child-function)). This behavior was added in 2016 via [this PR](yocontra/react-responsive#64) so it isn't a recent addition. Not trying to be a jerk here - I don't really care which module people use, but please don't spread misinformation as it just confuses people. Thanks.
|
Thanks for the PR! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've been seeing this comment circulate recently, which is incorrect. react-responsive supports render functions just fine (documented here). This behavior was added in 2016 via this PR so it isn't a recent addition.
Not trying to be a jerk here - I don't really care which module people use, but please don't spread misinformation as it just confuses people.
Thanks.