Skip to content

3.x: Javadocs: indicate takeUntil stops on completion of other #7341

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 27, 2021
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions src/main/java/io/reactivex/rxjava3/core/Flowable.java
Original file line number Diff line number Diff line change
Expand Up @@ -16972,9 +16972,9 @@ public final Flowable<T> takeUntil(@NonNull Predicate<? super T> stopPredicate)

/**
* Returns a {@code Flowable} that emits the items emitted by the current {@code Flowable} until a second {@link Publisher}
* emits an item.
* emits an item or completes.
* <p>
* <img width="640" height="380" src="https://raw.github.com/wiki/ReactiveX/RxJava/images/rx-operators/takeUntil.v3.png" alt="">
* <img width="640" height="188" src="https://raw.github.com/wiki/ReactiveX/RxJava/images/rx-operators/Flowable.takeUntil.p.png" alt="">
* <dl>
* <dt><b>Backpressure:</b></dt>
* <dd>The operator doesn't interfere with backpressure which is determined by the current {@code Flowable}'s backpressure
Expand All @@ -16984,7 +16984,7 @@ public final Flowable<T> takeUntil(@NonNull Predicate<? super T> stopPredicate)
* </dl>
*
* @param other
* the {@code Publisher} whose first emitted item will cause {@code takeUntil} to stop emitting items
* the {@code Publisher} whose first emitted item or completion will cause {@code takeUntil} to stop emitting items
* from the current {@code Flowable}
* @param <U>
* the type of items emitted by {@code other}
Expand Down
6 changes: 3 additions & 3 deletions src/main/java/io/reactivex/rxjava3/core/Observable.java
Original file line number Diff line number Diff line change
Expand Up @@ -14028,16 +14028,16 @@ public final Observable<T> takeLast(long time, @NonNull TimeUnit unit, @NonNull

/**
* Returns an {@code Observable} that emits the items emitted by the current {@code Observable} until a second {@link ObservableSource}
* emits an item.
* emits an item or completes.
* <p>
* <img width="640" height="380" src="https://raw.github.com/wiki/ReactiveX/RxJava/images/rx-operators/takeUntil.v3.png" alt="">
* <img width="640" height="213" src="https://raw.github.com/wiki/ReactiveX/RxJava/images/rx-operators/Observable.takeUntil.o.png" alt="">
* <dl>
* <dt><b>Scheduler:</b></dt>
* <dd>{@code takeUntil} does not operate by default on a particular {@link Scheduler}.</dd>
* </dl>
*
* @param other
* the {@code ObservableSource} whose first emitted item will cause {@code takeUntil} to stop emitting items
* the {@code ObservableSource} whose first emitted item or completion will cause {@code takeUntil} to stop emitting items
* from the current {@code Observable}
* @param <U>
* the type of items emitted by {@code other}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@

/**
* An interface extending {@link SimpleQueue} and {@link Disposable} and allows negotiating
* the fusion mode between subsequent operators of the {@link Observable} base reactive type.
* the fusion mode between subsequent operators of the {@link io.reactivex.rxjava3.core.Observable Observable} base reactive type.
* <p>
* The negotiation happens in subscription time when the upstream
* calls the {@code onSubscribe} with an instance of this interface. The
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@

/**
* An interface extending {@link SimpleQueue} and {@link Subscription} and allows negotiating
* the fusion mode between subsequent operators of the {@link Flowable} base reactive type.
* the fusion mode between subsequent operators of the {@link io.reactivex.rxjava3.core.Flowable Flowable} base reactive type.
* <p>
* The negotiation happens in subscription time when the upstream
* calls the {@code onSubscribe} with an instance of this interface. The
Expand Down