Skip to content

chore(package.json): add commit message format helper script #598

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

kwonoj
Copy link
Member

@kwonoj kwonoj commented Oct 26, 2015

This PR adds one additional script command npm run commit, which invokes cli based step by step commit message formatter follows convention in contributing guideline to help anyone who are new to codebase can easily compose commit message.

See how does wizard works in action:
commit

What's required if I don't need this helper but I can control git by myself completely?
: Do not need anything. Unless explicitly invoke npm run commit command, helper won't be able to do anything. This applies GUI client also, currently there isn't way hook this helper with GUI client.

@staltz
Copy link
Member

staltz commented Oct 26, 2015

Love it

@luisgabriel
Copy link
Contributor

👍

@benlesh
Copy link
Member

benlesh commented Oct 27, 2015

This is very cool. @IgorMinar @jeffbcross you might benefit from this module on the angular project if you're not already using it.

@kwonoj
Copy link
Member Author

kwonoj commented Oct 27, 2015

Honestly, I am inspired by angular repo's open issue (angular/angular.js#12730) and adopted into here first 😉

@benlesh
Copy link
Member

benlesh commented Oct 27, 2015

merged with 5f68356... great stuff, @kwonoj

@jimthedev
Copy link

@kwonoj per your comment about Git GUIs I've opened commitizen/cz-cli#45 to track this idea. Thanks!

@kwonoj
Copy link
Member Author

kwonoj commented Oct 28, 2015

@jimthedev It is so appreciate! I was actually curious if it could be possible.

@jimthedev
Copy link

@kwonoj I think it is possible assuming that they provide us some hook that we could wrap. I've not done much native node development so I'd probably reach out to community members on how to implement it, but as long as they implement the inquirer interface then I can see it being possible.

Thanks again for putting in this PR. RxJS is such a freaking awesome project.

@lock lock bot locked as resolved and limited conversation to collaborators Jan 18, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants