chore: migrate to dart sass #333
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
There was an unrelated build failure which i fixed in 093327b. PTAL @bproffitt |
bproffitt
approved these changes
Oct 24, 2022
🤔 |
|
Solution? I just see a lot of new PRs to bump tools up, but unclear if
that's related or coincedence.
BKP
…On Tue, Oct 25, 2022 at 9:00 AM Benny Powers ***@***.***> wrote:
https://github.com/RedHatOfficial/RedHatOfficial.github.io/actions/runs/3316451348/jobs/5488211102
Error: Dependencies lock file is not found in /home/runner/work/
RedHatOfficial.github.io/RedHatOfficial.github.io. Supported file
patterns: package-lock.json,npm-shrinkwrap.json,yarn.lock
🤔
—
Reply to this email directly, view it on GitHub
<#333 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAPIAZJIFGMCDGGBLDR7MW3WE7KWJANCNFSM6AAAAAAQYSAUCU>
.
You are receiving this because you modified the open/close state.Message
ID: ***@***.***
com>
|
|
not clear to me atm. i thought it could be that this action is running on the branch which contains the build gh-pages site, which wouldn't have the package-lock. does that seem likely to you? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #325 by updating sass dependencies
Testing instructions
npm startnpm buildMerging
Please squash when merging and ensure your commit message uses conventional commit formatting.
Further enhancement
I'm interested in writing a migration from angular to lit+red-hat-design-system? This would drastically reduce both the amount of code in this repo as well as the code over-the-wire to end user (thus improving loading performance), while updating the tech stack.