Skip to content

Enable AOF #255

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Dec 9, 2019
Merged

Enable AOF #255

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
9bfa583
Enable AOF
lantiga Dec 6, 2019
e5b0124
Enable AOF in tests via env conf
lantiga Dec 6, 2019
ea4d61f
Fix use of Env in tests. Run test suite multiple times with different…
lantiga Dec 9, 2019
4e81bf2
Comment out panda test
lantiga Dec 9, 2019
45fcd88
Update pack version and license in RAMP file
lantiga Dec 9, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion opt/Makefile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -134,8 +134,11 @@ ifneq ($(NO_LFS),1)
endif
$(SHOW)set -e ;\
cd $(ROOT)/test ;\
python3 -m RLTest $(TEST_ARGS) --test basic_tests.py --module $(INSTALL_DIR)/redisai.so ;\
python3 -m RLTest $(TEST_ARGS) --test basic_tests.py --module $(INSTALL_DIR)/redisai.so --use-slaves ;\
python3 -m RLTest $(TEST_ARGS) --test double-panda.py --module $(INSTALL_DIR)/redisai.so
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was failing on macOS, so this line actually waits for the macOS CI to be enabled. If we're convinced that everything is in order there, we can remove the rest of the test artifacts. Otherwise, it may be worthwhile to just comment it out until CI is ready.

python3 -m RLTest $(TEST_ARGS) --test basic_tests.py --module $(INSTALL_DIR)/redisai.so --use-aof
# Commented until the MacOS CI is available
# python3 -m RLTest $(TEST_ARGS) --test double-panda.py --module $(INSTALL_DIR)/redisai.so

#----------------------------------------------------------------------------------------------

Expand Down
5 changes: 3 additions & 2 deletions ramp.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,17 +3,18 @@ author: Orobix and RedisLabs
email: [email protected]
description: Serving tensors and executing deep learning graphs
homepage: https://oss.redislabs.com/redisai/
license: GNU Affero General Public License v3.0
license: Redis Source Available License v1.0
command_line_args: ""
min_redis_version: "5.0.7"
min_redis_pack_version: "5.4"
min_redis_pack_version: "5.4.11"
capabilities:
- types
- no_multi_key
- hash_policy
- eviction_expiry
- failover_migrate
- persistence_rdb
- persistence_aof
- clustering
exclude_commands:
- ai.modelset
Expand Down
2 changes: 0 additions & 2 deletions src/config.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,4 @@ typedef enum {
#define RAI_COPY_RUN_OUTPUT
#define RAI_PRINT_BACKEND_ERRORS

// #define RAI_OVERRIDE_AOF_CHECK

#endif /* SRC_CONFIG_H_ */
6 changes: 0 additions & 6 deletions src/redisai.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1486,12 +1486,6 @@ int RedisModule_OnLoad(RedisModuleCtx *ctx, RedisModuleString **argv, int argc)
== REDISMODULE_ERR) return REDISMODULE_ERR;

int flags = RedisModule_GetContextFlags(ctx);
if (flags & REDISMODULE_CTX_FLAGS_AOF) {
RedisModule_Log(ctx, "warning", "ERR: AOF currently unsupported\r\n");
#ifndef RAI_OVERRIDE_AOF_CHECK
return REDISMODULE_ERR;
#endif
}

RAI_BackendsPath = NULL;

Expand Down
Loading